Skip to content

docs: make README links registry-safe - #1117

Draft
seonghobae wants to merge 67 commits into
fix/eliminate-public-client-ropc-20260918from
docs/registry-readme-links
Draft

seonghobae wants to merge 67 commits into
fix/eliminate-public-client-ropc-20260918from
docs/registry-readme-links

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Current stacked authority — 2026-09-22 KST

This README follows the executable auth semantics it documents.

The buyer/operator documentation repair remains unchanged: RED 94f0f510c4495263faec4764bd598fd1f8bd65d4 pinned the current auth contract, and causal fix 2769b92172dd089ae9ffec207c9130abe057a728 documents Authorization Code + S256 PKCE for humans and separate confidential Client Credentials actors for machine integration while preserving registry-safe links.

The latest parent movement is ancestry-only: #1120 adopted #1118/#899 source-neutral live ancestry. Ordinary two-parent/non-force convergence 72341358... preserves this README lane exactly and inherits the current parent; no parent test/source is copied into the child-only delta.

Exact 72341358... must reacquire applicable hosted evidence. Keep Draft until the prerequisite stack is promotable and qualifying independent review exists.

No force push, destructive rebase, self-approval, gate weakening, stale-receipt transfer, owner-source duplication, new no-op wake commit, protected-main merge, or release is used.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 21d74d3d-6066-4284-acef-30af948d814e

📥 Commits

Reviewing files that changed from the base of the PR and between 8f077df and b43260f.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

README의 내부 문서 링크를 canonical GitHub 절대 URL로 변경했습니다. OIDC 라운드트립 검증 안내는 관련 스크립트 설명에서 make smoke 실행 안내로 변경했습니다.

Changes

README 링크 정규화

Layer / File(s) Summary
절대 GitHub 링크 및 검증 안내 적용
README.md
요구사항, 연구 자료, ADR 0084, 아키텍처 문서, ADR 0001, 라이선스 링크가 canonical GitHub URL을 사용합니다. OIDC 라운드트립 검증 안내는 make smoke 실행을 지시합니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b4326

The README-only update has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 README 링크를 레지스트리에서 안전하게 사용하도록 변경한 핵심 내용을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae changed the base branch from main to fix/contextual-orchestrator-owner-boundary September 18, 2026 01:50
@seonghobae
seonghobae marked this pull request as draft September 18, 2026 01:50

Copy link
Copy Markdown
Contributor Author

Fresh maintainer finding: the original README-only registry-link delta was mechanically mergeable on protected main, but that tree still contained the pre-#899 public provider/gateway configuration prose. Because #899 is the canonical contextual-orchestrator ownership-boundary writer and also edits README.md, allowing #1117 to publish independently would make the package/registry README externally resolvable while re-exposing ownership text that #899 is actively removing.

Repair applied without force/rebase or source duplication: ordinary two-parent convergence c69575c320b1749fc553089513c4ebdd8a392aea preserved prior #1117 ancestry and adopted exact #899 a2da5875525cd0950999487ff8fe7d439284dbd2; 7accb384866254e50f65e449d929947dc0b93b6f reapplies only the valid README-link/OIDC-smoke delta. PR base is now #899, Draft. Fresh compare is behind_by=0 with only README.md modified.

Predecessor b43260fc... review/check receipts are historical after both base and head movement. Exact child Tests 35296950964 is Draft-policy skipped; overlapping Tests 35296938692 was cancelled on lifecycle change; Security/SAST/CodeQL are still non-accepting. No merge/promotion is claimed.

Copy link
Copy Markdown
Contributor Author

Fresh operator-contract review found that the make smoke target referenced by this README lane does not itself activate the optional dependency set supplying jwt. I kept this PR README-only: #1118 is the separate Draft sibling on the same exact #899 parent and owns the Makefile/test repair at 9669a18c41a8122d9adffe18ccd4a1587e72ed56. Do not copy that target repair into #1117; both must inherit #899 first and validate independently.

@seonghobae
seonghobae changed the base branch from fix/contextual-orchestrator-owner-boundary to fix/oidc-smoke-declared-jwt-dependency September 18, 2026 03:54
@seonghobae
seonghobae changed the base branch from fix/oidc-smoke-declared-jwt-dependency to fix/eliminate-public-client-ropc-20260918 September 18, 2026 12:02

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head stack review at 1f0cbceb3445aeea76271ed7640bf6c25c102d1d: #1120 advanced test-only to 0808b081e7ac500c0181ed395743bd46b4c8b5b0. This README child adopts that exact parent via ordinary two-parent, non-force convergence. Fresh compare has merge-base 0808b081..., behind_by=0, and still only README.md plus tests/test_readme_auth_contract.py as child-owned delta. No valid README/test evidence was lost; previous receipts remain predecessor-only.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head stack review at 87b2f9fafb524beb0c6b99d30af6a4ad59c4e6d9: parent #1120 moved to 82723adb2d1fded5f3ba741ac957d3dd5bdd8891 for the JWKS-selector contract repair. This README child adopted that exact parent through an ordinary two-parent non-force merge. Fresh compare has merge-base 82723adb..., behind_by=0, and still only README.md plus tests/test_readme_auth_contract.py as child-owned delta. Exact-head Tests 35665060477 is Draft-policy skipped; predecessor receipts do not transfer.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant