fix(voice): preserve truth and derivation at historical cutoffs - #1139
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve the Voice cutoff repair while integrating the complete PyJWT and urllib3 security owner delta, RED contract, doctoring, CHANGELOG, generated lock, and product-gap evidence through ordinary two-parent ancestry.
Exact-head Security RCA and canonical-owner integration — current evidencePredecessor Fresh exact-head evidence:
No manual rerun, force update, destructive rebase, gate weakening, self-approval, or merge was performed. Independent approval is absent; Ready is review admission only. |
…urrent-main-20261003 # Conflicts: # docs/product-technical-gap-baseline.md
Current exact-head authority — 2026-10-01
421324c1b29d315d1987f69c3c16ce18a4330924; exact tree:cd6d790239a1e34d905b446a329d1b00e069e055.e627d90e6daed0836a6602573d9d50a57d957601and canonical dependency owner security(deps): enforce patched JWT and HTTP dependency floors #1137db96ff11c977a92180b5480884bc361a4be5cf75.36828592050, SAST36828591819, PROV-O36828591808, and Ontology Pages36828591758are GREEN.36828591967: Trivy, OSV, and Scorecard GREEN; Dependency Review remains fail-closed because GitHub's exact base/head dependency-graph request returned HTTP 403.36828591835dispatched all three exact-head shards successfully; each hasVERDICT_STATE=pendingand remains fail-closed until authenticated SARIF completion. No independent approval exists. Ready is review admission only; merge is HOLD.Superseded predecessor context
Updating an existing additional Voice overwrote its truth state, derivation assertion, and recording time. A historical cutoff could consequently lose its earlier evidence or acquire a later claim.
Serialize assignment writes with imported-primary changes on the carrying Post, retain closed intervals, and insert replacements at one database-clock boundary after the lock. An unchanged retry preserves its original interval. Post-detail and ontology reads omit additional rows recorded after the cutoff, including legacy rows whose earlier evidence was overwritten. ADR 0256 records the decision before implementation; the twelve atomic Voices and open composition contract remain unchanged.
Validation: 89 related tests passed with DeprecationWarning treated as an error, including full-migration synthetic PostgreSQL proof of truth-only and evidence-only revisions, retry idempotency, rollback, waiting writers, historical production read projections, and unchanged imported primary. Ruff and git diff --check passed. Temporary databases are dropped by fixture teardown.
Ownership and delivery: #1129 owns searched exports and paged JSON-LD; #1138 owns PROV derivation admission and remains stacked on dependency owner #1137. This change adds no schema migration, release number, estimation, provider selection, or UI design. Authenticated PostgreSQL HTTP/UI acceptance and authenticated synthetic k6 capacity evidence remain unverified. Hosted checks and independent approval are required on the current head before protected integration.
The Gap baseline records the exact-head queue, live rulesets, owner boundaries, API/ADR/migration/release identity collisions across the 177-PR observation, and the later 178-PR count. #1129's separate synthetic UI candidate passed 537 frontend tests and desktop/mobile screenshot/export checks; those results are not authenticated runtime or this PR's protected-delivery proof. The documentation follow-up advances this PR to e627d90 and requires fresh hosted checks and approval; the tested code remains abf66f8.