Skip to content

docs(voice): correct ADR mapping and record exact delivery evidence - #1147

Merged
seonghobae merged 2 commits into
mainfrom
codex/exact-head-voice-baseline-20261003
Oct 2, 2026
Merged

seonghobae merged 2 commits into
mainfrom
codex/exact-head-voice-baseline-20261003

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The supporting Voice requirements and ADR index incorrectly mapped evidence-bearing Voice combinations to ADR 0251. ADR 0251 governs the separate FJA/I-O psychology taxonomy; ADR 0256 governs evidence-bearing Voice combinations. This corrects those references and adds an exact-head baseline snapshot for the #1146 and #1142 merges.

The baseline records the confirmed merge SHAs separately from hosted-check and approval evidence. GitHub Actions annotated the affected jobs as not started because the account was locked for a billing issue. No formal approval was recorded for either merged head, and the available ruleset reads do not prove independent-approval or required-check enforcement. Voice acceptance remains incomplete pending authenticated PostgreSQL/API and populated authorized JSON-LD/UI evidence.

Validation: tests/test_documentation_hygiene.py (5 passed), git diff --check. No runtime code, schema, migration, or release number changed.


Devin Review

Summary by CodeRabbit

  • 문서
    • Voice 조합 기술 요구사항과 지원 문서 맵에서 기준 ADR 참조를 0256으로 정정했습니다.
    • ADR 0252의 상태 및 근거 참조를 갱신해 ADR 0256과의 관계를 반영했습니다.
    • 기술 현황 기준 문서에 관련 ADR의 역할, 병합 및 검증 상태, 열린 PR·이슈 현황을 최신 정보로 반영했습니다.
    • 타임스탬프 표시, 테스트·UI 관찰 내용, 인증된 Voice 수용 검증의 미완료 상태를 정리했습니다.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 57ffedd0-55eb-4868-93db-bd250fac56e4
📥 Commits

Reviewing files that changed from the base of the PR and between 9d401bc and a36e561.

📒 Files selected for processing (1)
  • docs/adr/0252-temporal-primary-voice-history.md
 _____________________________
< Reviewing code like a boss. >
 -----------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6bde72da-0ab6-4801-a0c0-a2fbd2beae03

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe1287 and 9d401bc.

📒 Files selected for processing (3)
  • docs/adr/README.md
  • docs/product-technical-gap-baseline.md
  • docs/voice-combination-technical-requirements.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

문서의 ADR 참조를 0256으로 수정했습니다. 제품 기술 갭 기준 문서에는 병합 및 검사 상태, 테스트 결과, 저장소 현황과 관련 변경의 의존성 정보를 추가했습니다.

Changes

기술 기준 문서 갱신

Layer / File(s) Summary
ADR 참조와 분류 정정
docs/adr/README.md, docs/voice-combination-technical-requirements.md, docs/product-technical-gap-baseline.md
지원 문서와 Voice 요구사항 문서의 ADR 참조를 0256으로 수정했습니다. 기준 문서에는 ADR 0246·0256의 Voice 분류와 ADR 0251의 별도 분류를 기록했습니다.
병합 및 검증 현황
docs/product-technical-gap-baseline.md
PR #1142·#1146의 병합 및 호스팅 검사 상태를 추가했습니다. 타임스탬프 표시 변경, 테스트·빌드 결과, Storybook 관찰 결과와 미완료 검증도 기록했습니다.
저장소와 변경 의존성 현황
docs/product-technical-gap-baseline.md
열린 PR·이슈 수와 PR #1141·#1137의 상태를 갱신했습니다. 관련 병합 관계, 의존성, RankWeave 이름·릴리스 계약 및 LineageWeave 변경의 비충돌 여부를 기록했습니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9d401

This PR only corrects documentation references and updates the status record. It does not change runtime behavior, so there is no merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to 9d401

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/adr/README.md: 지원 문서 맵의 ADR 번호 링크를 [0251]에서 [0256]으로 변경했습니다. 링크 대상 파일명은 변경되지 않았습니다.
  • observed — Modified behavior in docs/product-technical-gap-baseline.md: 새 기준일 제목과 규범적 권한·근거 섹션을 추가하고, Voice 분류에서 ADR 0246·0256과 별도 심리 분류에서 ADR 0251의 역할을 명시했습니다. 문서 갱신과 ADR 색인에서 ADR 0256을 0251로 잘못 표시하던 참조가 수정됐다고 기록합니다.
  • observed — Modified behavior in docs/product-technical-gap-baseline.md: PR #1142와 #1146의 병합 헤드·SHA 및 호스팅 검사 상태를 추가했습니다. 두 PR 모두 일반 자동 병합으로 병합됐지만 정확한 헤드의 호스팅 작업은 과금 잠금으로 시작되지 않았고 공식 승인이 없었으며, 관찰된 규칙 정보만으로 승인·필수 검사 집행을 확인할 수 없다고 명시합니다.
  • observed — Modified behavior in docs/product-technical-gap-baseline.md: 타임스탬프 표가 날짜 이후 값을 잘라내던 문제를 기록하고, #1142가 전체 제공 타임스탬프 표시와 누락값의 Unknown 표기로 바꿨다고 갱신했습니다. 합성 회귀 검사 범위와 통과한 로컬·프런트엔드 테스트 및 빌드 결과를 추가했습니다. Storybook의 데스크톱·모바일 렌더 결과와 별도로 인증된 Voice 저장·조회, JSON-LD 및 k6 검증은 미완료라고 명시합니다.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 Voice 문서의 ADR 매핑 수정과 정확한 전달 증거 기록이라는 주요 변경 사항을 명확하게 요약합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment on lines +8 to +10
normative. Voice-of-X uses ADR 0246 for its twelve atomic classes, ADR 0256
for evidence-bearing combinations, and ADR 0252 for temporal primary history.
ADR 0251 governs the separate FJA/I-O psychology taxonomy. The cited

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Voice history ADR retains stale cross-references

ADR 0252 still says it extends ADR 0251 and attributes Voice assignment history to it. ADR 0251 covers occupational psychology, leaving the normative Voice history record inconsistent with this corrected map.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@seonghobae
seonghobae merged commit 28f0c51 into main Oct 2, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant