docs(prd): reconcile occupational authority identities - #847
seonghobae merged 11 commits into
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughPRD의 직업 분류 범위를 승인된 자료로 제한했습니다. FJA I/O-Psychology 계층과 ADR 추적성을 갱신했습니다. ADR 참조, PRD 식별자, 현재 ADR의 역참조를 검증하는 문서 위생 검사를 추가했습니다. ChangesPRD 권위 및 문서 검증
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other · Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Align the ecosystem authority register with the protected remote name and add a documentation hygiene regression without promoting an unmerged local PRD. Signed-off-by: Codex <codex@localhost>
|
Exact-head audit found and fixed one remaining authority identity drift in 0b1dc95: the product authority register now preserves the protected remote canonical name ContextualWisdomLab/disksage, while retaining the protected-main design document because docs/PRD.md is not present on disksage main. A documentation-hygiene regression locks the canonical spelling. Focused result: 10 passed; Ruff passed. No unmerged local PRD was promoted. |
Signed-off-by: Codex <codex@localhost>
Adopt protected main #923's docs-only Tests workflow delta while preserving the occupational PRD/ADR identity repair unchanged.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh ancestry/live-authority finding: current head is ed11f7e44e54dac68c97e62cd89fcd101e2cfd90, not the stale a2295720... recorded in the body, and protected main@83eba56149eb802cd63642c507c324c9976ec78e is seven commits ahead of this branch's merge base 0f1d44726cc8fd9fd05a4f9b91ec40ff6be8802d. The protected-only delta is exactly the three repository-local Draft-admission workflows plus tests/test_tests_workflow_contract.py; it does not overlap this PR's occupational PRD/ADR/documentation-hygiene delta. Preserve all four valid documentation/test files and non-force converge the current protected workflow contract. Do not transfer predecessor gates/reviews or close the surviving authority repair.
1eb8f5f
into
codex/gap-baseline-exact-head-20260921
Closes #807 only when the composed occupational delta ultimately reaches protected
main; this stack-base merge is not protected delivery.Reconciles duplicated occupational PRD identifiers against protected-main ADR authority. Unsupported full SOC/content-model/linkage claims remain explicitly unavailable; Voice ADR 0256 stays distinct from occupational authority. Adds fail-closed documentation regressions for unique PRD identifiers and resolvable direct ADR references.
Single-writer succession — 2026-09-21
Fresh review found that #847 and #1123 had diverged from protected
main@83eba56149eb802cd63642c507c324c9976ec78ewhile both writingdocs/product-technical-gap-baseline.mdandtests/test_documentation_hygiene.py. The #847 baseline overlay was stale: it named predecessor9bb4f07a..., called this PR Draft after it was Ready, and exposed only a first-page PR lower bound instead of #1123's audited timestamp/cutoff snapshot.The branch was therefore reconstructed by ordinary two-parent/non-force convergence at
cd77fab8b623ff71c3fb71f22205ce4cff3d2cb3, preserving the occupational ADR/PRD delta and all valid hygiene tests while taking #11234023ac2b...as the gap-snapshot authority. Fresh compare had exact merge-base4023ac2b...,behind_by=0; the child-only delta was exactly three files: ADR 0245,docs/product-requirements.md, and the semantically combined documentation-hygiene test.docs/product-technical-gap-baseline.mdwas no longer a child-only delta.This PR had pre-existing squash auto-merge armed. After retargeting to
codex/gap-baseline-exact-head-20260921, GitHub normally squash-merged the three-file child delta into that non-default parent at1eb8f5f56c2b9038c937f6a428f83278e4e08700. The merge is valid stack composition, not protected-main delivery and not release evidence. It transferred no predecessor check receipt or approval. Exact successor #1123 now contains every valid #847 source/test delta together with its own queue-snapshot contract, so there is no second writer to reopen or duplicate.All pre-existing #847 review threads were resolved before succession, and there were no open PRs directly based on the #847 branch. Current protected delivery authority is therefore #1123 exact successor, not this closed PR. #1123 must obtain fresh exact-head required checks and qualifying independent approval before any protected integration.
No self-approval, admin bypass, force push, destructive rebase, gate weakening, stale receipt transfer, no-op wake commit, or release was used.