feat(i18n): consume published Customer Master screen copy - #932
seonghobae wants to merge 75 commits into
Conversation
Load the complete authenticated Customer Master translation resource before customer data and expose an explicit retry state when copy is unavailable. Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
📝 WalkthroughWalkthroughCustomer Master가 인증 후 화면 번역을 먼저 로드합니다. 번역이 준비되면 데이터를 요청합니다. 인증 토큰과 로케일이 변경되면 이전 요청을 무효화합니다. 8개 로케일의 부트스트랩 로딩·재시도 화면과 누락 번역의 영어 폴백을 추가했습니다. ChangesCustomer Master 번역 및 인증 생명주기
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant AuthLifecycle
participant CustomerMasterPanel
participant TranslationAPI
participant CustomerMasterAPI
AuthLifecycle->>CustomerMasterPanel: accessToken 또는 locale 변경
CustomerMasterPanel->>TranslationAPI: 현재 인증 정보로 번역 요청
TranslationAPI-->>CustomerMasterPanel: 화면 번역 응답
CustomerMasterPanel->>CustomerMasterAPI: 번역 준비 후 고객 데이터 요청
CustomerMasterAPI-->>CustomerMasterPanel: 현재 요청 세대의 결과 반환
CustomerMasterPanel-->>CustomerMasterPanel: 오래된 완료·오류·갱신 무시
Merge Risk: 🟡 Moderate · up to Rapidly reopening an entity can display stale related data, while Spanish, German, and French users receive English Ontology Explorer copy. Resolve both visible regressions before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Valid finding on the Customer Master translation cutover: copy readiness is bound to locale, but not to the access-token identity that authorized the screen resource. On an accessToken A→B rerender, the translation effect schedules copyState="loading", but the following data-load effect still observes the previous render's copyState === "ready"; loadMaster has already been recreated around token B, so /api/v1/customer-master can start before token B's published screen projection is admitted. The render guard has the same stale-ready window because copyLocale may still match. Please make the ready state auth-bound (or equivalently make the sequencing contract explicit and fail-closed) and add a regression that changes the access token while copy is ready and proves Customer Master data is not requested until the replacement translation resource succeeds. Keep this PR Draft until the repaired exact head has fresh UI/runtime evidence.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head finding: the translation-gate retry copy currently diagnoses every projection failure as “not published in the selected language yet”. fetchTranslationScreen() throws BackendError for transport failure, 401/403, 404, and 5xx, while the Customer Master effect collapses all of them into copyState="retry". The rendered message therefore turns permission/service failures into a publication claim and tells the operator to ask an administrator to publish copy even when publication may be healthy. That violates the explicit unavailable/failed/permission evidence boundary. Keep the retry state fail-closed, but make its copy cause-neutral until the caller carries a typed failure reason; do not imply unpublished copy from an unclassified exception. Add a focused regression before the product change.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head i18n review found a buyer-visible bootstrap gap outside the published screen resource: the Customer Master gate rendered raw English loading/retry copy while the selected product locale could be ko/ja/zh/vi/es/de/fr. Because this gate is shown before the versioned screen resource can be admitted, the database-backed resource cannot safely translate its own loading/failure shell. RED 51c766614d8303da96918e6d405481cd6b8a5569 requires the bootstrap shell and retry action to stay in all eight governed locales. 422064e7da5804c0d985c197c9cd52687acc57fe adds an optional already-localized label/description boundary to shared StatusNotice without changing ordinary callers; 078f47d51aa120c1f901b15cd3d8e63567581a47 supplies the bounded eight-locale bootstrap copy and keeps failure wording cause-neutral. Do not treat the static bootstrap strings as reviewed material Customer Master copy or as replacement for the PostgreSQL translation ledger. Exact-head hosted Tests are Draft-skipped, so product GREEN is not claimed.
seonghobae
left a comment
There was a problem hiding this comment.
Valid auth-transition finding on this exact head: translation readiness is bound to (locale, accessToken), but the Customer Master data projection itself is not invalidated until the post-render data effect runs. When accessToken changes from A→B, the render gate correctly stays closed while B copy loads; once B copy becomes ready, React can render one frame with copyAccessToken === B while master still contains A-authorized data, because setMaster(null) is only executed later inside the second effect immediately before B's fetch. An A request that resolves late can also repopulate master because loadMaster() has no stale-token completion guard. This is a purpose-bound data/auth boundary defect, not a translation-copy issue. Add RED coverage that a token transition invalidates the customer data projection before B copy can unlock rendering and that stale A completions cannot publish into B state; then minimally bind master response admission to the current token/generation. Keep this Draft behind #929 and do not weaken the existing translation gate.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh parent check: #929 advanced non-force from f07a755… to 2a8ed5d… with a test-only review-quality delta in three translation foundation test files. Those files are disjoint from #932’s Customer Master consumer delta. I adopted the parent changes non-force by rebuilding the child tree with the exact parent blobs and joining the new parent at a0ebd1fb60890f31e5408fc196e2af633d03fd41; compare now reports #929 as the exact merge base with behind_by=0. The existing stale-auth Customer Master RED remains intentionally unresolved, so this is ancestry convergence only, not GREEN or Ready evidence.
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review found a second purpose-bound authorization leak beyond the repaired master response. relatedByEntity survives an access-token change and toggleEntity() can publish a late response from the old token after the transition; selectedPostGraph and canResolveHints also retain the old authorization projection until their replacement effects complete. Once the new translation gate becomes ready, those secondary projections can reappear under the new token (especially when entity/post identities overlap). The fix must invalidate all Customer Master-owned secondary projections on auth transition and reject late async completions by the current auth identity; do not rely only on the translation gate or the masterRequestGeneration counter.
|
@codex address that feedback Work only on current exact head |
|
To use Codex here, create an environment for this repo. |
|
@codex address that feedback Repair only the verified current-head Customer Master auth/data RED from review 5120072275 on exact head fe01453. Keep this presentation/read-model local. On access-token identity transition, invalidate Customer Master secondary authorization-derived state ( |
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
|
Parent-hosted-failure authority refresh: #929 remains exact The parent Tests failure is now causally narrower than the body wording. Run Exact-parent checked-in workflow/config does not contain the observed isolated-workspace construction, pytest addopts, No parent acceptance transfers to this child; no blind rerun/wake commit, merge, or release is justified. |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review: #932 adopted parent #929 314be833... through ordinary two-parent 9c6d87b...; fresh compare has exact merge-base=current parent, 70 ahead / 0 behind, while the effective 25-file consumer delta is preserved. The inherited change is the Customer Master retired-seed rollback repair only; no child runtime semantics were rewritten. Exact-head Tests are Draft-policy skipped and the parent contract is still unpublished/unaccepted, so no predecessor evidence transfers and this COMMENT is not approval.
Product delta
Customer Master consumes an authenticated, versioned
customer-masterscreen projection before requesting customer records. PostgreSQL publication/version/cache/seed-ownership authority remains in parent #929; this child owns Customer Master presentation/read-model consumption and request lifecycle only.Current exact authority — 2026-09-25
feat/i18n-versioned-translation-ledger@f076fa46976b2f68942a6e066cdbcf8895ba16f44cfe2fe57352590f85010df6f2555c4b0e4eca4aParent convergence
#929 performed owner-side buyer-language review of the Customer Master
Resolve/Resolving...hint action. RED44c6ccc4...showed the prior localized copy described generic solving/finalization/parsing rather than the governed task of identifying/verifying an organization from a source hint; repairf076fa46...corrects the seven translated presentation values while preserving resolver/auth/ontology semantics and keeping the 37×8 resource in Draft.This child adopted that exact parent through ordinary non-force two-parent convergence
4cfe2fe57352590f85010df6f2555c4b0e4eca4a. Its existing Customer Master consumer/UI delta is preserved. No force push, destructive rebase, parent-source duplication, or predecessor evidence transfer was used.The parent-side correction is not immutable publication and is not qualifying independent language approval. This child therefore still has no published contract to treat as release evidence.
Current acceptance state
Exact-head Tests
36023704803are skipped by Draft policy and are not acceptance evidence. Parent #929 likewise lacks executable exact-head PostgreSQL/full-suite GREEN, complete Security/SAST/CodeQL/Strix/model acceptance, qualifying independent language/product approval, and publication.#996 separately owns malformed-hierarchy presentation repair. Promotion still requires current parent #929 to become admissible and publish the reviewed 37×8 contract, followed by this unchanged child’s authenticated consumer/full-suite/Security/SAST/CodeQL/browser/a11y/responsive/CJK/text-expansion/font-fallback/performance evidence and qualifying independent approval.
Keep Draft. Do not Ready-cycle for checks, enable auto-merge, add wake commits, synthesize status, self-approve, weaken gates, force-push, destructively rebase, copy parent/central-owner source, merge, or release.