Skip to content

preserve(ui): duplicate Settings/Help tooltips pending #1193 #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

preserve(ui): duplicate Settings/Help tooltips pending #1193 #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6522573
refactor: replace native title with Tooltip for accessibility
seonghobae Sep 21, 2026
4a6f8ea
chore(ui): remove local Vite output artifact
seonghobae Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 25 additions & 20 deletions apps/desktop/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Progress } from "@/components/ui/progress";
import { Toaster } from "@/components/ui/sonner";
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";

const ANALYSIS_POLL_INTERVAL_MS = 250;
const MAX_ERROR_DETAIL_LENGTH = 220;
Expand Down Expand Up @@ -611,26 +612,30 @@ export function App() {
</div>

<div className="flex items-center justify-between text-slate-400">
<button
type="button"
aria-disabled={true}
aria-label={t("settingsComingSoon")}
title={t("settingsComingSoon")}
onClick={preventUnavailableAction}
className="inline-flex cursor-not-allowed items-center justify-center rounded-xl p-2 text-slate-600 transition focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300"
>
<Settings className="size-5" aria-hidden="true" />
</button>
<button
type="button"
aria-disabled={true}
aria-label={t("helpComingSoon")}
title={t("helpComingSoon")}
onClick={preventUnavailableAction}
className="inline-flex cursor-not-allowed items-center justify-center rounded-xl p-2 text-slate-600 transition focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300"
>
<CircleHelp className="size-5" aria-hidden="true" />
</button>
<Tooltip>
<TooltipTrigger
type="button"
aria-disabled="true"
aria-label={t("settingsComingSoon")}
onClick={preventUnavailableAction}
className="inline-flex cursor-not-allowed items-center justify-center rounded-xl p-2 text-slate-600 transition focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 aria-disabled:opacity-50 aria-disabled:cursor-not-allowed"
>
<Settings className="size-5" aria-hidden="true" />
</TooltipTrigger>
<TooltipContent>{t("settingsComingSoon")}</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger
type="button"
aria-disabled="true"
aria-label={t("helpComingSoon")}
onClick={preventUnavailableAction}
className="inline-flex cursor-not-allowed items-center justify-center rounded-xl p-2 text-slate-600 transition focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 aria-disabled:opacity-50 aria-disabled:cursor-not-allowed"
>
<CircleHelp className="size-5" aria-hidden="true" />
</TooltipTrigger>
<TooltipContent>{t("helpComingSoon")}</TooltipContent>
</Tooltip>
</div>
</div>
</aside>
Expand Down
Loading