π‘οΈ Sentinel: [HIGH] Fix SSRF/LFI vulnerability by restricting FFmpeg protocols - #687
seonghobae wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit detailsLimit details: Youβve used the included review currently available. Review configuration: βοΈ Run configuration
π Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: SSRF/LFI μ·¨μ½μ . FFmpeg/FFprobe μ€ν μ μΈλΆ νλ‘ν μ½ μ κ·Ό μ νμ΄ μμ΄ μ μμ μΈ λ―Έλμ΄ νμΌ λΆμ μ μ격 μ½λλ λ΄λΆ λ€νΈμν¬ λ°μ΄ν° μ μΆ μνμ΄ μ‘΄μ¬ν©λλ€.
π― Impact: 곡격μκ° μ μμ μΌλ‘ μ‘°μλ λ―Έλμ΄ νμΌ(HLS νλ μ΄λ¦¬μ€νΈ λ±)μ μ λ‘λν κ²½μ°, μλ²κ° λ΄λΆ μλΉμ€λ μΈλΆλ‘ μμΉ μλ λ€νΈμν¬ μμ²μ λ³΄λ΄ λ°μ΄ν° μ μΆμ΄ λ°μν μ μμ΅λλ€.
π§ Fix: FFmpeg λ° FFprobe λͺ λ Ήμ΄ μΈμμ
"-protocol_whitelist", "file,crypto,data"λ₯Ό λͺ μμ μΌλ‘ μΆκ°νμ¬ μμ ν λ‘컬 νλ‘ν μ½λ§ μ¬μ©νλλ‘ μ ννμ΅λλ€. λν, μ λ ₯ νμΌ κ²½λ‘ μμ"-i"μΈμλ₯Ό λͺ ννκ² μΆκ°νμ¬ λͺ λ Ήμ΄ μΈμ μ μ λ°©μ§νμ΅λλ€.β Verification: μ 체 ν μ€νΈ μ€μνΈλ₯Ό μ€ννμ¬ νκ· λ¬Έμ κ° μμμ νμΈνμ΅λλ€.
PR created automatically by Jules for task 9414448873409242833 started by @seonghobae