Skip to content

Remove deprecated Draw feature and lasting references to previously deprecated Search and Post features - #1805

Open
Purplegaze wants to merge 8 commits into
Courseography:masterfrom
Purplegaze:remove-deprecated
Open

Purplegaze wants to merge 8 commits into
Courseography:masterfrom
Purplegaze:remove-deprecated

Conversation

@Purplegaze

@Purplegaze Purplegaze commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Removes code relating to the old Draw page, which has been deprecated, along with CSS and dependencies that were only used for that page, such as jscolor.min.js.
  • Removes a few lasting references to the previously deprecated Search and Post features, which had their code removed in Remove search and post #1549 and Remove search and post (v2) #1558.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Sep 24, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36170316794

Coverage increased (+0.1%) to 59.94%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
app/MasterTemplate.hs 2 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 4321
Covered Lines: 2644
Line Coverage: 61.19%
Relevant Branches: 1001
Covered Branches: 546
Branch Coverage: 54.55%
Branches in Coverage %: Yes
Coverage Strength: 156.51 hits per line

💛 - Coveralls

@Purplegaze

Purplegaze commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Issues relating to these deprecated features --
post: #486 #566 #580
search: #701 #702 #704 #705 #706 #707
draw: #700 #856 #919 #1045 #1077
Should these all be closed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants