Repository navigation
test: de-flake git-spawn; win32 portability for exec-git-config spec (CI gate part 1) - #119
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI 门禁第 1 部分(钉子①②,外加钉子③中不涉及 workflow 的那一半)。改
.github/workflows/ci.yml(恢复 Test blocking / Test summary)需要 workflow scope,单独跟进。① exec-git-config:win32 下路径统一正斜杠;
a|b.txt只在非 Windows 跑;0o700/uid 断言仅 win32 跳过(产品在 win32 本就不查)。hooks 相关 3 条在 win32 显式 skip({ skip: reason }/t.skip(reason),Windows 上显示为 skipped 而不是 pass,共 4 skip):断言只适用 POSIX(按执行位识别钩子);Windows 由 O76 无条件注入core.hooksPath=NUL覆盖,不是安全 bug(撤回早先说法)。Windows CI 已确认qa-repro-o76-git-hooksPASS、git-config-env-win32-hooks2 pass / 1 skip。Linux/macOS 断言未放宽。② git-spawn 抖动:预检改为
git config --get filter.mossinc.clean+ 裸git diff(总会过 filter),对 Moss 本身的断言不变。③(范围扩大)
scripts/run-package-tests.mjs:CI为真时跑完全部测试文件,最后汇总失败文件列表并非零退出;本地(无 CI 或CI=false)仍遇错即停。新增test/run-package-tests-ci.spec.mjs(本地 fail-fast、CI 全量+汇总、CI=false 仍 fail-fast;撤掉改动后 CI 用例变红)。不在本 PR 内:Windows 上仍红的 exec-git-config 2 条(spec:400 discovery cache 的 hooksPath 期望;git diff 的 O77 回归——
git-builtin-diff路径反斜杠被吃掉,#73 曾修过)、git-spawn 的 Windows 夹具预检,以及其余约 25 个此前被 fail-fast 遮住的 Windows 红文件,全部记入 Windows 失败分诊表另开小 PR。本地 Node 22.16:相关测试与 npm run check 绿。代码由 Developer 手写。