Repository navigation
feat(cli): O99 show real progress during long runs - #95
Closed
QiaolongLi1201 wants to merge 2 commits into
Closed
QiaolongLi1201 wants to merge 2 commits into
QiaolongLi1201 wants to merge 2 commits into
Conversation
Emit real progress at least every 60s on TUI and --print (stderr only): tool start/end summaries, long-tool heartbeats via tool_progress, and thinking-wait lines. Map existing tool_execution_progress heartbeats; no empty working… slogans; unfinished runs get a clear last line on the progress path (full false-success exit-code gate depends on O98/#94). Display only — no safety/scheduling change.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Live spinner now shows the in-flight tool summary instead of Working…. Update tui-run-state and tui-shell assertions; narrow panes may clip token/queue tails after the tool line.
Collaborator
Author
|
Superseded by fix/o99-progress-v2 (rebased onto main |
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
O99 — show real progress during long runs so users do not think Moss is hung and hit Ctrl+C.
--print(stderr only for print; stdout keeps the final answer).tool_progressheartbeats → thinking-wait lines (正在推理,已等待 Ns/ English equivalent) when the model is silent ≥30s.tool_execution_progressintoMossAgentEvent.tool_progress(previously dropped).working…/ rotating slogans; identical lines do not stack ≥3 times.Unfinished:/未完成:…).src/safety, tool scheduling, or default permissions.Depends on O98 (#94)
Full unfinished exit-code / false-success gate is owned by O98 (#94). This PR lands the progress heartbeat + unfinished footer on the progress path and can merge independently while #94 is still open.
When/if O98 is present, O99 only reads run-outcome for display alignment; it does not own
RunOutcome(completed|incomplete|verify_failed|blocked|unverified),formatOutcomeLine, ornoteGoalVerifyResult. Do not treat progress lines as a success signal. Once #94 lands, unfinished / false-success exit codes are complete end-to-end.Test plan
node --test test/o99-progress.spec.mjs→ 13/13 passcli-output+output-renderer-edit-diff→ 15 pass;cli-headless-json-contract+background-completion-user-visible→ 2 pass;oneshot-cancellation→ 1 passnpm run check(format / lint / typecheck) → greensrc/, deleterun-progress.ts, rebuild → 1 pass / 12 fail (only the main-green detail-mode guard stays green)tui-run-state+tui-shellto expect real tool progress in the live spinner (follow-up commit0e3ef243)npm testafter TUI retarget (prior full run stopped on the old live-slogan assert; re-run pending CI)--print≥5 min, stderr 60s window check (post-merge)Files
src/cli/run-progress.tssrc/cli/output.ts--printtracker; unfinished last line; drop empty working…src/cli/oneshot.tssrc/cli/print.tstool_progress→ no stdout eventssrc/cli/tui/transcript.tssrc/cli/tui/render-bridge.tstool_progressrefreshes toolLinesrc/core/agent/moss-agent-types.tstool_progresseventsrc/core/agent/moss-agent-loop-adapter.tstool_execution_progresstest/o99-progress.spec.mjstest/cli-output.spec.mjsworking…Base:
58c9e3d6(post-O94 #93). Head:0e3ef243. Nosrc/safetychanges.