Skip to content

fix: version_release workflow fails for fork PRs - #295

Merged
johentsch merged 1 commit into
mainfrom
fix/release-workflow-fork-prs
Oct 7, 2026
Merged

johentsch merged 1 commit into
mainfrom
fix/release-workflow-fork-prs

Conversation

@johentsch

@johentsch johentsch commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Problem

version_release.yml failed on merged PRs from forks (e.g. run 37618258202, head repo e7mac/corelli) with Input required and not supplied: token. Workflows triggered by pull_request from forks get no secrets, so secrets.MS3_BOT_TOKEN was empty (Secret source: None in the log).

Fix

Trigger on pull_request_target (types: closed) instead. It runs in the base repo context with secrets available. This is safe because the job only checks out the base branch (github.event.pull_request.base.ref) and never executes code from the PR head. github.event.pull_request.* fields used by the workflow remain available.

Note

pull_request_target uses the workflow file from the default branch, so this takes effect only after merge. The already-failed release for the fix/key-label-op03n03d PR must be re-run/handled manually.

pull_request workflows triggered by fork PRs receive no secrets, so
checkout failed with "Input required and not supplied: token"
(MS3_BOT_TOKEN empty). pull_request_target runs in the base repo context
with secrets. Safe because the job only checks out the base branch.
@johentsch
johentsch force-pushed the fix/release-workflow-fork-prs branch from e603a89 to de2e1ca Compare October 7, 2026 21:01
@johentsch
johentsch merged commit 5644a5c into main Oct 7, 2026
@johentsch
johentsch deleted the fix/release-workflow-fork-prs branch October 7, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant