Build the network model result on mikeio1d's topology layer - #702

Merged

jpalm3r merged 119 commits into

mainfrom

network-phase-2

Oct 2, 2026

Commits on Aug 25, 2026

Record the decision to move the network topology layer to mikeio1d

jpalm3r
and
claude
committed
21265dc
Note the proposed move to mikeio1d in the network roadmap entry

jpalm3r
and
claude
committed
9d3d1c6
Accept ADR-013 now that the upstream module exists

jpalm3r
and
claude
committed
4c8e92d
Locate network observations with a MIKE+ database

jpalm3r
and
claude
committed
c9dc5b1
Document locating observations from a MIKE+ database

jpalm3r
and
claude
committed
34d3aad
Identify a network timeseries by name, not by graph integer

jpalm3r
and
claude
committed
62486c7
Take the network topology layer from mikeio1d

jpalm3r
and
claude
committed
72ec69d
Build the network model result on mikeio1d's topology layer

jpalm3r
and
claude
committed
f6765b6
Drop the integer form of NodeObservation's at=

jpalm3r
and
claude
committed
dfc9fe4
Point the docs and the records at the upstream module

jpalm3r
and
claude
committed
7f9efc6
Keep a 1.4.0a3 comparer loading

jpalm3r
and
claude
committed
c81faf3
Say plainly what the ADRs now record

jpalm3r
and
claude
committed
c9ef75b
Cut the flourishes from the network ADRs

jpalm3r
and
claude
committed
6999d61

Commits on Sep 3, 2026

merge latest changes from main
jpalm3r
committed
181b2b5
Potential fix for pull request finding 'Statement has no effect'

jpalm3r
and
github-code-quality[bot]
authored
a178762
Potential fix for pull request finding 'Statement has no effect'

jpalm3r
and
github-code-quality[bot]
authored
8294657
Potential fix for pull request finding 'Statement has no effect'

jpalm3r
and
github-code-quality[bot]
authored
64bb87a
Merge branch 'network-phase-2' of https://github.com/DHI/modelskill into network-phase-2
jpalm3r
committed
27babc8
Add reach branch to Comparer.to_dataframe
jpalm3r
committed
62df504
Guard node extraction against locations with no data
jpalm3r
committed
904e5f0
Fix Option B breakpoint example in the network guide
jpalm3r
committed
ec14d7b
Match MIKE+ source on the file name, not a substring
jpalm3r
committed
38c120e
Keep unclassifiable MIKE+ stations from aborting a resolve
jpalm3r
committed
1123857
Treat a Quantity passed with db= as metadata only
jpalm3r
committed
04e93ad
Rewrite ADR-013 to the point
jpalm3r
committed
71be06c
Move the network location reader next to NodeObservation

jpalm3r
and
claude
committed
137dfaf
Read a NodeObservation's location through one function

jpalm3r
and
claude
committed
3fcea06
State the network-coordinate rule once, on GeometryType

jpalm3r
and
claude
committed
f5d4711
Read a coordinate off a dataset through one function

jpalm3r
and
claude
committed
52f0711
Take the network vocabulary off the TimeSeries base

jpalm3r
and
claude
committed
525e876
Give the network parsers a module of their own

jpalm3r
and
claude
committed
a5b0ae2

Commits on Sep 4, 2026

Name the network scope in from_network_coords

jpalm3r
and
claude
committed
4a50c0d
Keep the coordinate reader in the coordinate module

jpalm3r
and
claude
committed
c6beb58
Read a network location from the coordinate module

jpalm3r
and
claude
committed
50fe132
Test the network module through its public surface

jpalm3r
and
claude
committed
aac8db1
Reach the network comparers through modelskill's own names

jpalm3r
and
claude
committed
a8ba234
Match a reach observation end to end

jpalm3r
and
claude
committed
bc6e446
Run the doctests that state the network-coordinate rule

jpalm3r
and
claude
committed
dffb909
Moving constant
jpalm3r
committed
61babd0
Fix network plotting in example notebook
jpalm3r
committed
9b5d164
Include tests for network values passed to the comparer
jpalm3r
committed
0be65c2
Reusing existing fixtures
jpalm3r
committed
d2995a1
Move function to network_helpers
jpalm3r
committed
173fe46
Assert the network values survive item selection and the file path

jpalm3r
and
claude
committed
77545a1
Remove NetworkModelResult.nodes

jpalm3r
and
claude
committed
5f4d838

Commits on Sep 21, 2026

Remove the MIKE+ station lookup

jpalm3r
and
claude
committed
95e9ce7
Drop the MIKE+ section from the network guide

jpalm3r
and
claude
committed
ebcede0
Take the MIKE+ station resolver off ADR-013's ownership table

jpalm3r
and
claude
committed
57f5199
Read the network quantity off the attributes directly

jpalm3r
and
claude
committed
eae79e0

Commits on Sep 22, 2026

pin mikeio1d to alpha release
jpalm3r
committed
4a8a14c
pin mikeio1d to alpha release
jpalm3r
committed
fb885ba
Run the file-backed network tests on 3.14

jpalm3r
and
claude
committed
9e885c3
Run the network notebook again

jpalm3r
and
claude
committed
7681792
Build the docs on 3.14

jpalm3r
and
claude
committed
1107be3
Guard the network fixtures on mikeio1d, not networkx

jpalm3r
and
claude
committed
86eee4f
Stop handing Comparer.load a name it ignores

jpalm3r
and
claude
committed
4df5a6d
Build NodeModelResult only from data that knows where it is

jpalm3r
and
claude
committed
aeafce2
Drop the NodeModelResult _create_new_instance override

jpalm3r
and
claude
committed
52ef693
Describe NetworkModelResult by what it takes

jpalm3r
and
claude
committed
86aaa5f
Seed the synthetic sensor data in the network notebook

jpalm3r
and
claude
committed
ee60c4a
Test NodeModelResult and its recorded graph integer

jpalm3r
and
claude
committed
945b8ac
Run the file-backed network tests on EPANET too

jpalm3r
and
claude
committed
0e9ebdf
Carry an observation's aux items into the comparer

jpalm3r
and
claude
committed
af1a59b
Say what a reach with no values is missing

jpalm3r
and
claude
committed
f66fe83
Copy the dataset before marking it a model result

jpalm3r
and
claude
committed
208abad
Refuse a node location the data contradicts

jpalm3r
and
claude
committed
b11c068
Refuse a reach location the data contradicts

jpalm3r
and
claude
committed
831db3a

Commits on Sep 23, 2026

Build the test networks from result files

jpalm3r
and
claude
committed
bf77e67

Commits on Sep 24, 2026

Pin mikeio1d to the issue-250 branch

jpalm3r
and
claude
committed
e08b109
Read a network location only when it is extracted

jpalm3r
and
claude
committed
1408277
Point the integer location error at the graph alias

jpalm3r
and
claude
committed
f4e6691
Describe the lazy network model result in the guide

jpalm3r
and
claude
committed
73850f0
Use resolve and graph aliases in the network notebook

jpalm3r
and
claude
committed
163d0b2

Commits on Sep 25, 2026

Read a resolved location's fields as attributes

jpalm3r
and
claude
committed
d095fb5
Name the graph attribute address, as mikeio1d now does

jpalm3r
and
claude
committed
a5a9f39
Run the network notebook on the Location surface

jpalm3r
and
claude
committed
994560d
Plot the temporal coverage of a comparer saved by 1.4.0a3

jpalm3r
and
claude
committed
dac0f53
Build a comparer's observation at a node name it can take

jpalm3r
and
claude
committed
5bcb6cd
Build a NetworkModelResult from model_result()

jpalm3r
and
claude
committed
3ed2a74
Give a network model result the at its observation has

jpalm3r
and
claude
committed
baffb46
Give a comparer the at its observation has

jpalm3r
and
claude
committed
3926f0e
Merge the node and reach coords into one NetworkCoords

jpalm3r
and
claude
committed
8278f4b
Build network timeseries through _parse_point_input directly

jpalm3r
and
claude
committed
4344e22
Drop the node_index coordinate

jpalm3r
and
claude
committed
da66d0a
Fold _from_network into _read_at

jpalm3r
and
claude
committed
ad21400
Say a location is missing without rebuilding mikeio1d's search

jpalm3r
and
claude
committed
f1648f0
Read a reach observation's break points once

jpalm3r
and
claude
committed
70ea520
introducing network_gtype function
jpalm3r
committed
3485b79

Commits on Sep 30, 2026

Follow mikeio1d main, where the network PR merged

jpalm3r
and
claude
committed
6175d80
Point network hints at the surface mikeio1d now has

jpalm3r
and
claude
committed
f97e8eb
Say that EPANET pipe lengths come from the .res

jpalm3r
and
claude
committed
4d73572
Run the network notebook on mikeio1d main

jpalm3r
and
claude
committed
482874c
Read node_series nodes from network.addresses

jpalm3r
and
claude
committed
c28b9a4
Drop epanet.inp, which nothing reads

jpalm3r
and
claude
committed
6b7f085
Rename the network distance coordinate to position

jpalm3r
and
claude
committed
806cc80
Rerun collection systems network with new mikeio1d
jpalm3r
committed
3115d78

Commits on Oct 1, 2026

Pin mikeio1d 1.4.0
jpalm3r
committed
7c4fc69
Drop the 1.4.0a3 comparer fixture

jpalm3r
and
claude
committed
2c807ae
Describe the network layer against mikeio1d 1.4.0

jpalm3r
and
claude
committed
2228945
Drop graph integers from the network notebook

jpalm3r
and
claude
committed
6638045
Generate a discharge sensor on reach 116l1

jpalm3r
and
claude
committed
9e31f0f
Match the guide's sensors where they were generated

jpalm3r
and
claude
committed
ab1d0b2
Describe network extraction as it happens

jpalm3r
and
claude
committed
bd1e854
Say ADRs 012 and 013 read no EPANET .inp

jpalm3r
and
claude
committed
4157140
Describe NetworkModelResult's contents and name default correctly

jpalm3r
and
claude
committed
cf51e7d
Show a comparer's location in its repr

jpalm3r
and
claude
committed
7da099f
Print an undefined quantity as Undefined, and drop empty unit brackets

jpalm3r
and
claude
committed
0f8a163
Reserve network coordinate names

jpalm3r
and
claude
committed
a81a778
Resolve a node observation with the model's item

jpalm3r
and
claude
committed
44544ae
Let a node observation set its chainage tolerance

jpalm3r
and
claude
committed
982a276
Explain position_tol in the network user guide

jpalm3r
and
claude
committed
4a8ed33
Keep the reach observation's location on a reach comparer

jpalm3r
and
claude
committed
64b8fbc
Give reach observations and comparers an .at

jpalm3r
and
claude
committed
ccc5ca8
Say where a reach comparer sits in the network user guide

jpalm3r
and
claude
committed
1314a00
Drop the Python 3.15 skips from the network tests

jpalm3r
and
claude
committed
152c8df
Delete network tests a stronger test already covers

jpalm3r
and
claude
committed
2310812
Fold the reach location test into the reach comparer test

jpalm3r
and
claude
committed
52289d7
Place a comparer's raw model results at the observation

jpalm3r
and
claude
committed
bc943a7
Read the break point a model used from the model in the network guide

jpalm3r
and
claude
committed
28c0780