Repository navigation
docs(rewards_claim): replace stale "not yet wired" claims - #638
Merged
Merged
Conversation
Refs DIG-Network/dig_ecosystem#3441 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Author
|
security audit (loop-security) — PR #638 @ afb2656 PASS
Not covered: runtime behaviour (no code changed). KG: NONE (doc-only, no durable finding). |
MichaelTaylor3d
commented
Oct 6, 2026
MichaelTaylor3d
left a comment
Contributor
Author
There was a problem hiding this comment.
PASS at afb2656 (loop-reviewer, independent gate).
Verified against code at head:
- config.rs R5: spawn gated by
decide_claim_driver(enabled, enable_chain_sync)(driver.rs:645), called viaspawn_claim_driver_from_config(driver.rs:695) from server.rs:2374 withconfig.enable_chain_sync; unbuildable source ->set_refusal(ClaimDriverRefusal::ChainSourceUnbuildable)then return, no cycle (driver.rs:362); mod.rs:36 heading "# Wired into node startup" exists. - engine.rs: doc sits on
pub(crate) fn with_persisted_fee_window;run_claim_driver_in_with_clock(driver.rs:558) calls.with_persisted_fee_window(at :601. True. - driver.rs test doc: engine built with
UnavailableClaimChainPort, which returns onlyErr(ClaimPortError::Unavailable). True. - port.rs: "No chain source is reachable" correct for
Unavailable. - No new sentence asserts another ticket's landed/not-landed status (the stale "#3268, not yet landed" / "Not yet wired" text is removed;
grep -c 'Not yet wired' mod.rs= 0). - Intra-doc links: no new links; only pre-existing
[crate::rewards_claim].ClaimDriverRefusal::ChainSourceUnbuildableis in backticks, not a link. - Doc-comment-only diff: YES (4 files, only
///lines changed) -> eligible for the section 2.4c docs-only path.
Not run: cargo doc / CI (not needed for comment-only diff; confirm required checks green before merge). Out of scope per brief: types.rs:265.
Open threads: 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stale "not yet wired" claims in rewards_claim doc comments.
Changes:
crates/dig-node-service/src/rewards_claim/config.rs:63-68— R5 comment now describes actual wiring (enabled + sync both true)crates/dig-node-service/src/rewards_claim/engine.rs:248-250— driver.rs now calls wiring method in productioncrates/dig-node-service/src/rewards_claim/driver.rs:1863— clarify "no chain adapter" → "chain port always Unavailable"crates/dig-node-service/src/rewards_claim/port.rs:16— "is wired yet" → "is reachable"Refs DIG-Network/dig_ecosystem#3441
🤖 Generated with Claude Code