Skip to content

docs(rewards_claim): replace stale "not yet wired" claims - #638

Merged
MichaelTaylor3d merged 2 commits into
developfrom
loop/3441-rewards-claim-doc
Oct 6, 2026
Merged

MichaelTaylor3d merged 2 commits into
developfrom
loop/3441-rewards-claim-doc

Conversation

@MichaelTaylor3d

Copy link
Copy Markdown
Contributor

Replace stale "not yet wired" claims in rewards_claim doc comments.

Changes:

  • crates/dig-node-service/src/rewards_claim/config.rs:63-68 — R5 comment now describes actual wiring (enabled + sync both true)
  • crates/dig-node-service/src/rewards_claim/engine.rs:248-250 — driver.rs now calls wiring method in production
  • crates/dig-node-service/src/rewards_claim/driver.rs:1863 — clarify "no chain adapter" → "chain port always Unavailable"
  • crates/dig-node-service/src/rewards_claim/port.rs:16 — "is wired yet" → "is reachable"

Refs DIG-Network/dig_ecosystem#3441

🤖 Generated with Claude Code

@MichaelTaylor3d

Copy link
Copy Markdown
Contributor Author

security audit (loop-security) — PR #638 @ afb2656

PASS

  • Non-doc changed lines: 0 (23 +/- lines, all /// or //!; verified by grep over gh pr diff).
  • config.rs R5 text: consistent with decide_claim_driver (driver.rs:645): Spawn only when enabled AND enable_chain_sync; otherwise Disabled / ChainSyncDisabled. ClaimDriverRefusal::ChainSourceUnbuildable exists in driver.rs, so the "zero cycles" claim is grounded. An operator is not misled either way ("necessary, not sufficient").
  • No code, dependency, or persisted-state change.

Not covered: runtime behaviour (no code changed). KG: NONE (doc-only, no durable finding).

@MichaelTaylor3d MichaelTaylor3d left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS at afb2656 (loop-reviewer, independent gate).

Verified against code at head:

  • config.rs R5: spawn gated by decide_claim_driver(enabled, enable_chain_sync) (driver.rs:645), called via spawn_claim_driver_from_config (driver.rs:695) from server.rs:2374 with config.enable_chain_sync; unbuildable source -> set_refusal(ClaimDriverRefusal::ChainSourceUnbuildable) then return, no cycle (driver.rs:362); mod.rs:36 heading "# Wired into node startup" exists.
  • engine.rs: doc sits on pub(crate) fn with_persisted_fee_window; run_claim_driver_in_with_clock (driver.rs:558) calls .with_persisted_fee_window( at :601. True.
  • driver.rs test doc: engine built with UnavailableClaimChainPort, which returns only Err(ClaimPortError::Unavailable). True.
  • port.rs: "No chain source is reachable" correct for Unavailable.
  • No new sentence asserts another ticket's landed/not-landed status (the stale "#3268, not yet landed" / "Not yet wired" text is removed; grep -c 'Not yet wired' mod.rs = 0).
  • Intra-doc links: no new links; only pre-existing [crate::rewards_claim]. ClaimDriverRefusal::ChainSourceUnbuildable is in backticks, not a link.
  • Doc-comment-only diff: YES (4 files, only /// lines changed) -> eligible for the section 2.4c docs-only path.

Not run: cargo doc / CI (not needed for comment-only diff; confirm required checks green before merge). Out of scope per brief: types.rs:265.
Open threads: 0.

@MichaelTaylor3d
MichaelTaylor3d marked this pull request as ready for review October 6, 2026 21:34
@MichaelTaylor3d
MichaelTaylor3d merged commit 7212df8 into develop Oct 6, 2026
13 checks passed
@MichaelTaylor3d
MichaelTaylor3d deleted the loop/3441-rewards-claim-doc branch October 6, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant