Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ft_cachesthread-safety reference infontcache.cso it's only referenced underUSE_THREAD[...]bracket expressions for PCRE2 (mapcompositingfilter.c,mapregex.c/h) so PCRE2's regex handling matches POSIX regex semantics<?xmlSVG symbol data inmapcairo.c, not just file paths for RSVG to support svg legend and scalebarsvgoutput (notcairopng) whenUSE_RSVGis the active SVG backend, not justUSE_SVG_CAIRO(maplegend.c,mapscale.c)__try/__exceptSEH usage incsmodule.ibehindWIN32 && SWIGCSHARP- GCC has no equivalent and fails to parse itrenderer_free_funcassignments to their declaredvoid (*)(symbolObj *)type, fixing GCC 14's-Wincompatible-pointer-types(promoted to an error by default in GCC 14) inmaplegend.c,maprendering.c,mapsymbol.cmssql2008plugin'sUSE_ICONVwide-char ODBC path (SQLDriverConnectW/SQLExecDirectW/SQL_WCHAR) assuming a 2-bytewchar_t- true on Windows, false on Linux/glibc's 4-bytewchar_t- which corrupted connection strings, SQL text, and query results on Linux. Restricted that path to_WIN32; other platforms use the existing narrow-char path.Test plan
mssql2008-backed layers return correct data on Linux (previously returned SQL Server syntax errors from corrupted query text)