Add AODS opaque data parsing. - #3531
Open
Li-Aaron wants to merge 1 commit into
Open
Conversation
Li-Aaron
force-pushed
the
fix-2936
branch
2 times, most recently
from
February 25, 2026 05:57
3585563 to
4aac6f6
Compare
Li-Aaron
changed the title
Li-Aaron
force-pushed
the
fix-2936
branch
3 times, most recently
from
February 26, 2026 02:58
e445113 to
c358c96
Compare
Li-Aaron
changed the title
Li-Aaron
marked this pull request as ready for review
March 2, 2026 01:51
Member
|
I recommend to split the commit to 2:
|
Signed-off-by: Aaron Li <aaron.li@intel.com>
Contributor
Author
|
rebased after #3541 merged. |
ayj
reviewed
Jul 10, 2026
ayj
left a comment
ayj
left a comment
There was a problem hiding this comment.
Minor typo: credetial_id should be credential_id
typedef struct {
uint8_t aods_id;
uint8_t presence_extension;
- uint16_t credetial_id;
+ uint16_t credential_id;
} aods_general_opaque_element_invoke_seap_t;While this field is a binary uint16_t on the wire and does not impact protocol serialization, fixing the spelling aligns with the DMTF DSP0289 specification terminology (credential_id) and improves maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2936