Change REST Contract for statistics reports#75
Conversation
| } | ||
| ``` | ||
| ## Report View Events endpoint | ||
| **GET /api/statistics/viewevents** |
There was a problem hiding this comment.
I don't think this endpoint is the right place for statistics reports. Since you use it to POST one event at a time, you would expect to GET events with the same level of detail, and that's not very useful for a report. Reports are usually about a combination of a few aspects of a number of events at the same time. e.g. the most popular items in the repository, where we need to facet the view events on item id.
I envision reports will get a dedicated endpoint e.g. /api/statistics/reports that will return data in some json equivalent of a table format
There was a problem hiding this comment.
I agree. That was my mistake to leave the endpoint as is. I will change it.
|
Hi @dimitrispie, |
|
This pull request has been automatically marked as stale because it has not had Allowing pull requests to close as stale helps us filter out old work that is no longer All pull requests closed by this bot act like normal pull requests; If these changes are still relevant then please comment and/or rebase your PR based on the |
No description provided.