Skip to content

Change REST Contract for statistics reports#75

Open
dimitrispie wants to merge 1 commit into
DSpace:mainfrom
dimitrispie:openaire-dspace7-statistics
Open

Change REST Contract for statistics reports#75
dimitrispie wants to merge 1 commit into
DSpace:mainfrom
dimitrispie:openaire-dspace7-statistics

Conversation

@dimitrispie

Copy link
Copy Markdown

No description provided.

Comment thread statistics.md
}
```
## Report View Events endpoint
**GET /api/statistics/viewevents**

@artlowel artlowel Sep 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this endpoint is the right place for statistics reports. Since you use it to POST one event at a time, you would expect to GET events with the same level of detail, and that's not very useful for a report. Reports are usually about a combination of a few aspects of a number of events at the same time. e.g. the most popular items in the repository, where we need to facet the view events on item id.

I envision reports will get a dedicated endpoint e.g. /api/statistics/reports that will return data in some json equivalent of a table format

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. That was my mistake to leave the endpoint as is. I will change it.

@dimitrispie dimitrispie changed the title Change contract for statistics reports Change REST Contract for statistics reports Sep 5, 2019
@tdonohue
tdonohue changed the base branch from master to main July 13, 2020 20:45
@github-actions github-actions Bot added the merge conflict PR has a merge conflict that needs resolution label Nov 30, 2023
@github-actions

Copy link
Copy Markdown

Hi @dimitrispie,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions Bot added the stale label Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict PR has a merge conflict that needs resolution stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants