Skip to content

fix(sampling): record rate limiter's effective rate on allow, not just drop #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Jul 30, 2026
Merged

fix(sampling): record rate limiter's effective rate on allow, not just drop #2288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01edb8
fix(sampling): record rate limiter's effective rate on allow, not jus…
MilanGarnier Jul 28, 2026
5117c2b
Merge branch 'main' into milan.garnier/otel-rate-limiter-effective-rate
MilanGarnier Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions libdd-sampling/src/datadog_sampler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,13 @@ impl DatadogSampler {

if !rule.sample(trace_id) {
is_keep = false;
} else if !self.rate_limiter.is_allowed() {
// Rule kept the span, but the rate limiter dropped it.
is_keep = false;
} else {
// Record the limiter's effective rate whether it allows or drops the trace.
let allowed = self.rate_limiter.is_allowed();
rl_effective_rate = Some(self.rate_limiter.effective_rate());
if !allowed {
is_keep = false;
}
}
} else {
let service_key = self.service_key(span);
Expand Down
Loading