Skip to content

chore(rc): add DEBUG product - #2306

Draft
KowalskiThomas wants to merge 1 commit into
mainfrom
kowalski/chore-rc-add-debug-product
Draft

chore(rc): add DEBUG product#2306
KowalskiThomas wants to merge 1 commit into
mainfrom
kowalski/chore-rc-add-debug-product

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@github-actions

github-actions Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📚 Documentation Check Results

⚠️ 678 documentation warning(s) found

📦 libdd-remote-config - 678 warning(s)

Updated: 2026-07-30 15:01:35 UTC | Commit: 4228c3c | missing-docs job results

@github-actions

github-actions Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔒 Cargo Deny Results

⚠️ 2 issue(s) found, showing only errors (advisories, bans, sources)

📦 libdd-remote-config - 2 error(s)

Show output 
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:94:1
   │
94 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
   │
   ├ ID: RUSTSEC-2026-0097
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
   ├ It has been reported (by [@lopopolo](https://github.com/lopopolo)) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
     
     - The `log` and `thread_rng` features are enabled
     - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
     - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
     - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
     - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
     
     `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
   ├ Announcement: https://github.com/rust-random/rand/pull/1763
   ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
   ├ rand v0.8.5
     └── (dev) libdd-common v5.1.0
         ├── libdd-capabilities-impl v3.0.0
         │   └── libdd-remote-config v2.0.0
         │       └── (dev) libdd-remote-config v2.0.0 (*)
         └── libdd-remote-config v2.0.0 (*)

error[vulnerability]: Denial of Service via Stack Exhaustion
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:138:1
    │
138 │ time 0.3.41 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0009
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0009
    ├ ## Impact
      
      When user-provided input is provided to any type that parses with the RFC 2822 format, a denial of
      service attack via stack exhaustion is possible. The attack relies on formally deprecated and
      rarely-used features that are part of the RFC 2822 format used in a malicious manner. Ordinary,
      non-malicious input will never encounter this scenario.
      
      ## Patches
      
      A limit to the depth of recursion was added in v0.3.47. From this version, an error will be returned
      rather than exhausting the stack.
      
      ## Workarounds
      
      Limiting the length of user input is the simplest way to avoid stack exhaustion, as the amount of
      the stack consumed would be at most a factor of the length of the input.
    ├ Announcement: https://github.com/time-rs/time/blob/main/CHANGELOG.md#0347-2026-02-05
    ├ Solution: Upgrade to >=0.3.47 (try `cargo update -p time`)
    ├ time v0.3.41
      └── libdd-remote-config v2.0.0
          └── (dev) libdd-remote-config v2.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-07-30 15:01:39 UTC | Commit: 4228c3c | dependency-check job results

@KowalskiThomas
KowalskiThomas force-pushed the kowalski/chore-rc-add-debug-product branch from c06bac2 to 04f8214 Compare July 30, 2026 14:59
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 30, 2026 •
edited by datadog-prod-us1-3 Bot
Loading

Copy link
Copy Markdown
Contributor

Pipelines  Tests

⚠️ Warnings

🚦 2 Pipeline jobs failed

semver-check | validate   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Cargo semver validation failed due to a new enum variant added in 'libdd-remote-config'. Major API changes require a breaking change marker in the PR title or footer.

Required checks pass | allchecks   View in Datadog   GitHub Actions

See error Some checks have failed or timed out, please check the workflow run summary to get the details
📋 Copy prompt for your agent 
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: kowalski/chore-rc-add-debug-product

semver-check | validate
Commit: 4228c3cca27ba3cf0e4ee8c3fb4cde98163643f3
Error (code / build):
Cargo semver validation failed due to a new enum variant added in 'libdd-remote-config'. Major API changes require a breaking change marker in the PR title or footer.
CI job: https://github.com/DataDog/libdatadog/actions/runs/30554487858/job/90912549078

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 74.84% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 04f8214 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.13 MB 85.13 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.82 MB 7.82 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.51 MB 10.51 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 96.27 MB 96.27 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.14 MB 25.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 183.32 MB 183.33 MB +0% (+16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 938.88 MB 938.88 MB +0% (+832 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.22 MB 8.22 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.30 MB 24.30 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.47 MB 48.47 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.79 MB 21.79 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 187.41 MB 187.41 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 927.44 MB 927.44 MB +0% (+774 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.35 MB 6.35 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.09 MB 26.09 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 46.11 MB 46.11 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 75.88 MB 75.88 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.34 MB 91.34 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.59 MB 10.59 MB 0% (0 B) 👌

@pr-commenter

pr-commenter Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-07-30 16:04:40

Comparing candidate commit 04f8214 in PR branch kowalski/chore-rc-add-debug-product with baseline commit 5761c06 in branch main.

Found 17 performance improvements and 30 performance regressions! Performance is the same for 224 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:concentrator/add_spans_to_concentrator

  • 🟩 execution_time [-1.197ms; -1.190ms] or [-12.499%; -12.426%]

scenario:datadog_sample_span/multiple_rules_last_match/wall_time

  • 🟥 execution_time [+14.716ns; +14.831ns] or [+7.470%; +7.528%]

scenario:datadog_sample_span/tag_rule_matching/wall_time

  • 🟩 execution_time [-17.477ns; -17.320ns] or [-5.143%; -5.096%]

scenario:ddsketch_encode/encode_to_vec/clustered_near_zero

  • 🟥 execution_time [+41.057ns; +45.743ns] or [+5.864%; +6.533%]

scenario:ddsketch_encode/encode_to_vec/large_values

  • 🟥 execution_time [+66.366ns; +71.382ns] or [+7.856%; +8.450%]

scenario:ddsketch_encode/encode_to_vec/mixed

  • 🟥 execution_time [+93.805ns; +99.199ns] or [+7.697%; +8.140%]

scenario:ddsketch_read/ordered_bins/clustered_near_zero

  • 🟩 execution_time [-261.420ns; -259.154ns] or [-4.610%; -4.570%]

scenario:ddsketch_read/ordered_bins/collapsing

  • 🟩 execution_time [-1.142µs; -1.132µs] or [-4.527%; -4.486%]

scenario:glob_matcher/ascii_case_insensitive_match/wall_time

  • 🟩 execution_time [-1.262ns; -1.245ns] or [-4.469%; -4.408%]

scenario:glob_matcher/ascii_exact_match/wall_time

  • 🟩 execution_time [-1.508ns; -1.477ns] or [-5.342%; -5.233%]

scenario:glob_matcher/ascii_exact_miss/wall_time

  • 🟩 execution_time [-1.882ns; -1.853ns] or [-14.029%; -13.815%]

scenario:glob_matcher/ascii_wildcard_question_match/wall_time

  • 🟩 execution_time [-21.162ns; -21.129ns] or [-36.496%; -36.439%]

scenario:glob_matcher/ascii_wildcard_star_match/wall_time

  • 🟩 execution_time [-21.020ns; -21.000ns] or [-36.372%; -36.338%]

scenario:glob_matcher/unicode_pattern_ascii_subject/wall_time

  • 🟥 execution_time [+5.068ns; +5.120ns] or [+5.621%; +5.680%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟥 execution_time [+18.091µs; +18.214µs] or [+9.692%; +9.758%]
  • 🟥 throughput [-476359.077op/s; -473260.872op/s] or [-8.892%; -8.834%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+961.933ns; +983.811ns] or [+5.385%; +5.508%]
  • 🟥 throughput [-2923827.809op/s; -2859736.953op/s] or [-5.222%; -5.108%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+40.796µs; +41.078µs] or [+8.231%; +8.288%]
  • 🟥 throughput [-154459.581op/s; -153417.397op/s] or [-7.655%; -7.604%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+22.661µs; +22.776µs] or [+13.477%; +13.545%]
  • 🟥 throughput [-709570.999op/s; -706131.971op/s] or [-11.931%; -11.874%]

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟥 execution_time [+2.013µs; +2.039µs] or [+5.565%; +5.638%]
  • 🟥 throughput [-1476433.682op/s; -1457007.733op/s] or [-5.340%; -5.269%]

scenario:sql/obfuscate_sql_string

  • 🟥 execution_time [+18.899µs; +19.145µs] or [+6.723%; +6.810%]

scenario:trace_buffer/2_senders/no_delay

  • 🟥 execution_time [+46.784µs; +52.445µs] or [+5.247%; +5.881%]
  • 🟥 throughput [-112797.177op/s; -100525.889op/s] or [-5.586%; -4.978%]

scenario:vec_map/as_deduped_map/needs_dedup_1_in_10/16

  • 🟥 execution_time [+31.890ns; +32.274ns] or [+4.507%; +4.561%]

scenario:vec_map/as_deduped_map/needs_dedup_1_in_2/16

  • 🟥 execution_time [+41.024ns; +41.438ns] or [+4.431%; +4.476%]

scenario:vec_map/contains_key/16

  • 🟥 execution_time [+10.914ns; +11.295ns] or [+4.364%; +4.517%]
  • 🟥 throughput [-2765962.170op/s; -2673976.507op/s] or [-4.323%; -4.179%]

scenario:vec_map/contains_key/8

  • 🟥 execution_time [+7.780ns; +8.395ns] or [+10.725%; +11.572%]
  • 🟥 throughput [-11364460.235op/s; -10616101.696op/s] or [-10.305%; -9.626%]

scenario:vec_map/get_hit/128

  • 🟩 execution_time [-2.970µs; -2.959µs] or [-18.015%; -17.947%]
  • 🟩 throughput [+1698759.653op/s; +1704884.104op/s] or [+21.883%; +21.962%]

scenario:vec_map/get_hit/16

  • 🟩 execution_time [-50.408ns; -50.220ns] or [-20.137%; -20.062%]
  • 🟩 throughput [+16050126.019op/s; +16105048.497op/s] or [+25.112%; +25.197%]

scenario:vec_map/get_hit/64

  • 🟩 execution_time [-728.336ns; -725.098ns] or [-16.642%; -16.568%]
  • 🟩 throughput [+2905453.225op/s; +2917737.608op/s] or [+19.869%; +19.953%]

scenario:vec_map/get_hit/8

  • 🟩 execution_time [-12.490ns; -12.440ns] or [-18.802%; -18.726%]
  • 🟩 throughput [+27762540.872op/s; +27873277.667op/s] or [+23.053%; +23.145%]

scenario:vec_map/get_mut/128

  • 🟥 execution_time [+1.670µs; +1.770µs] or [+11.780%; +12.482%]
  • 🟥 throughput [-1007090.565op/s; -949189.764op/s] or [-11.152%; -10.511%]

scenario:vec_map/get_mut/16

  • 🟥 execution_time [+20.110ns; +30.056ns] or [+7.214%; +10.782%]
  • 🟥 throughput [-5916461.953op/s; -3879691.777op/s] or [-10.214%; -6.698%]

scenario:vec_map/get_mut/64

  • 🟥 execution_time [+439.547ns; +479.185ns] or [+11.291%; +12.309%]
  • 🟥 throughput [-1814782.771op/s; -1661638.304op/s] or [-11.032%; -10.101%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KowalskiThomas