Skip to content

feat: add github shared caching - #2308

Draft
Aaalibaba42 wants to merge 1 commit into
mainfrom
jwiriath/APMSP-3799-github-cache
Draft

feat: add github shared caching#2308
Aaalibaba42 wants to merge 1 commit into
mainfrom
jwiriath/APMSP-3799-github-cache

Conversation

@Aaalibaba42

Copy link
Copy Markdown
Contributor

What does this PR do?

Add shared caching

Motivation

Have shared caching

Additional Notes

Ticket

How to test the change?

Dashboard

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 31, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 74.94% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e846dfd | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.01 MB 8.01 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.32 MB 87.32 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 98.55 MB 98.55 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.78 MB 10.78 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.05 MB 26.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 89.60 KB 89.60 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.10 MB 188.11 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 980.77 MB 980.77 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.49 MB 8.49 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 89.60 KB 89.60 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.10 MB 25.10 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 49.93 MB 49.93 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.69 MB 22.69 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 91.00 KB 91.00 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 192.87 MB 192.87 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 969.41 MB 969.41 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.56 MB 6.56 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 91.00 KB 91.00 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.97 MB 26.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.53 MB 47.53 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 77.87 MB 77.87 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.93 MB 8.93 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 93.36 MB 93.36 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.87 MB 10.87 MB 0% (0 B) 👌

@pr-commenter

pr-commenter Bot commented Jul 31, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-07-31 14:20:19

Comparing candidate commit e846dfd in PR branch jwiriath/APMSP-3799-github-cache with baseline commit 7b8cb2a in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 139 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:profile_add_sample_frames_x1000

  • 🟥 execution_time [+163.315µs; +164.296µs] or [+4.003%; +4.027%]

scenario:profiles_dictionary/profile_string_inserts/threads/1

  • 🟥 execution_time [+18.227µs; +21.752µs] or [+6.087%; +7.264%]
  • 🟥 throughput [-232931.100op/s; -195057.762op/s] or [-6.811%; -5.704%]

Benchmark execution time: 2026-07-31 14:34:58

Comparing candidate commit e846dfd in PR branch jwiriath/APMSP-3799-github-cache with baseline commit 7b8cb2a in branch main.

Found 9 performance improvements and 11 performance regressions! Performance is the same for 147 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:alloc_free/system/4096

  • 🟥 execution_time [+12.029ns; +12.160ns] or [+14.698%; +14.858%]

scenario:datadog_sample_span/name_pattern_rule_not_matching/wall_time

  • 🟩 execution_time [-12.138ns; -12.045ns] or [-6.815%; -6.763%]

scenario:datadog_sample_span/resource_pattern_rule_not_matching/wall_time

  • 🟥 execution_time [+8.224ns; +8.320ns] or [+5.174%; +5.234%]

scenario:datadog_sample_span/root_span_no_rules/wall_time

  • 🟥 execution_time [+8.414ns; +8.484ns] or [+6.845%; +6.901%]

scenario:datadog_sample_span/service_rule_not_matching/wall_time

  • 🟥 execution_time [+8.558ns; +8.633ns] or [+6.440%; +6.496%]

scenario:datadog_sample_span/tag_rule_not_matching/wall_time

  • 🟥 execution_time [+8.343ns; +8.473ns] or [+5.846%; +5.937%]

scenario:ddsketch_encode/into_pb/clustered_near_zero

  • 🟥 execution_time [+6.824ns; +7.360ns] or [+20.078%; +21.652%]

scenario:ddsketch_encode/into_pb/collapsing

  • 🟥 execution_time [+6.802ns; +7.759ns] or [+17.998%; +20.529%]

scenario:ddsketch_encode/into_pb/large_values

  • 🟥 execution_time [+6.920ns; +7.575ns] or [+20.104%; +22.008%]

scenario:ddsketch_encode/into_pb/mixed

  • 🟥 execution_time [+6.696ns; +7.595ns] or [+18.884%; +21.421%]

scenario:ddsketch_read/ordered_bins/clustered_near_zero

  • 🟩 execution_time [-389.133ns; -386.561ns] or [-6.696%; -6.652%]

scenario:ddsketch_read/ordered_bins/collapsing

  • 🟩 execution_time [-2.167µs; -2.156µs] or [-8.241%; -8.201%]

scenario:ddsketch_read/ordered_bins/large_values

  • 🟩 execution_time [-497.971ns; -494.996ns] or [-6.683%; -6.643%]

scenario:ddsketch_read/ordered_bins/mixed

  • 🟩 execution_time [-777.679ns; -771.893ns] or [-6.828%; -6.778%]

scenario:glob_matcher/ascii_pattern_unicode_subject/wall_time

  • 🟥 execution_time [+6.167ns; +6.228ns] or [+4.356%; +4.399%]

scenario:no_profiler/short_circuit/4096

  • 🟥 execution_time [+9.773ns; +9.956ns] or [+10.499%; +10.696%]

scenario:profiler_attached/fast_path_system/4096

  • 🟩 execution_time [-4.912ns; -4.755ns] or [-4.736%; -4.585%]

scenario:profiler_attached/slow_path_system/4096

  • 🟩 execution_time [-26.973ns; -26.908ns] or [-17.363%; -17.321%]

scenario:trace_buffer/4_senders/no_delay

  • 🟩 execution_time [-276.496µs; -240.566µs] or [-11.261%; -9.797%]
  • 🟩 throughput [+160421.324op/s; +184367.918op/s] or [+10.924%; +12.554%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant