Skip to content

chore(ci): Prototype: SMP client-side report rendering - #2324

Draft
Arpafaucon wants to merge 7 commits into
mainfrom
greg/smp-ci-reporting
Draft

Arpafaucon wants to merge 7 commits into
mainfrom
greg/smp-ci-reporting

Conversation

@Arpafaucon

Copy link
Copy Markdown
Contributor

Summary

Use a SMP binary generated by https://github.com/DataDog/single-machine-performance/pull/4693/s

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

@dd-octo-sts dd-octo-sts Bot added the area/ci CI/CD, automated testing, etc. label Aug 13, 2026
@Arpafaucon Arpafaucon changed the title [SMP] Prototype: client-side report rendering chore(SMP) Prototype: client-side report rendering Aug 13, 2026
@Arpafaucon
Arpafaucon force-pushed the greg/smp-ci-reporting branch from c4803f8 to 8948e88 Compare August 13, 2026 08:15
@Arpafaucon Arpafaucon changed the title chore(SMP) Prototype: client-side report rendering chore(SMP): Prototype: client-side report rendering Aug 13, 2026
@Arpafaucon Arpafaucon changed the title chore(SMP): Prototype: client-side report rendering chore(ci): Prototype: SMP client-side report rendering Aug 13, 2026
@Arpafaucon
Arpafaucon marked this pull request as ready for review August 13, 2026 08:29
@Arpafaucon
Arpafaucon requested a review from a team as a code owner August 13, 2026 08:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8948e88e8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitlab/benchmark.yml Outdated

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The standalone report job cannot invoke the new renderer because its fresh workspace receives only report artifacts and the CI image does not include smp; every PR benchmark report therefore stops before posting its condensed comment.

Open Bits AI session

🤖 Datadog Autotest · Commit 8948e88 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread .gitlab/benchmark.yml Outdated
@Arpafaucon
Arpafaucon marked this pull request as draft August 13, 2026 09:08
@pr-commenter

pr-commenter Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: b51122c · Comparison: 5671ba1 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.08 MiB (baseline) vs 40.07 MiB (comparison)
Size Change: -600 B (-0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.0be5f78d782786092fb03f5ea0bcf0de.2.llvm.5482277008123388336 -793 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.2.llvm.414197936547421355 +792 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.31.llvm.11831773883379952737 -646 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.31.llvm.5365063242480902090 +645 B 1
_RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.11831773883379952737 -579 B 1
_RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.5365063242480902090 +578 B 1
_RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.5482277008123388336 -578 B 1
_RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.414197936547421355 +577 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.480.llvm.5482277008123388336 -551 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.480.llvm.414197936547421355 +549 B 1
_RNvXsZ_NtCsgW8esjfipvk_5alloc6stringNtB5_6StringNtNtCs27Vx93FoQ6z_4core3fmt5Write10write_char.llvm.5482277008123388336 -511 B 1
_RNvXsZ_NtCsgW8esjfipvk_5alloc6stringNtB5_6StringNtNtCs27Vx93FoQ6z_4core3fmt5Write10write_char.llvm.414197936547421355 +510 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.114.llvm.5482277008123388336 -476 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.114.llvm.414197936547421355 +475 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.112.llvm.5482277008123388336 -474 B 1
anon.0be5f78d782786092fb03f5ea0bcf0de.112.llvm.414197936547421355 +473 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.1181.llvm.11831773883379952737 -470 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.1181.llvm.5365063242480902090 +469 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.1187.llvm.11831773883379952737 -469 B 1
anon.884b1e16ac60104c4744bd22c43a82d6.1187.llvm.5365063242480902090 +468 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +792  [NEW]     +76    anon.0be5f78d782786092fb03f5ea0bcf0de.2.llvm.414197936547421355
  [NEW]    +645  [NEW]    +104    anon.884b1e16ac60104c4744bd22c43a82d6.31.llvm.5365063242480902090
  [NEW]    +578  [NEW]    +473    _RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.5365063242480902090
  [NEW]    +577  [NEW]    +473    _RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.414197936547421355
  [NEW]    +549  [NEW]      +4    anon.0be5f78d782786092fb03f5ea0bcf0de.480.llvm.414197936547421355
  [NEW]    +510  [NEW]    +367    _RNvXsZ_NtCsgW8esjfipvk_5alloc6stringNtB5_6StringNtNtCs27Vx93FoQ6z_4core3fmt5Write10write_char.llvm.414197936547421355
  [NEW]    +475  [NEW]     +22    anon.0be5f78d782786092fb03f5ea0bcf0de.114.llvm.414197936547421355
  [NEW]    +473  [NEW]     +20    anon.0be5f78d782786092fb03f5ea0bcf0de.112.llvm.414197936547421355
  [NEW]    +469  [NEW]    +104    anon.884b1e16ac60104c4744bd22c43a82d6.1181.llvm.5365063242480902090
  [NEW]    +468  [NEW]    +105    anon.884b1e16ac60104c4744bd22c43a82d6.1187.llvm.5365063242480902090
  [DEL]    -469  [DEL]    -105    anon.884b1e16ac60104c4744bd22c43a82d6.1187.llvm.11831773883379952737
  [DEL]    -470  [DEL]    -104    anon.884b1e16ac60104c4744bd22c43a82d6.1181.llvm.11831773883379952737
  [DEL]    -474  [DEL]     -20    anon.0be5f78d782786092fb03f5ea0bcf0de.112.llvm.5482277008123388336
  [DEL]    -476  [DEL]     -22    anon.0be5f78d782786092fb03f5ea0bcf0de.114.llvm.5482277008123388336
  [DEL]    -511  [DEL]    -367    _RNvXsZ_NtCsgW8esjfipvk_5alloc6stringNtB5_6StringNtNtCs27Vx93FoQ6z_4core3fmt5Write10write_char.llvm.5482277008123388336
  [DEL]    -551  [DEL]      -4    anon.0be5f78d782786092fb03f5ea0bcf0de.480.llvm.5482277008123388336
  [DEL]    -578  [DEL]    -473    _RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.5482277008123388336
  [DEL]    -579  [DEL]    -473    _RNvXsZ_NtNtCs27Vx93FoQ6z_4core3fmt3numjNtB7_5Debug3fmt.llvm.11831773883379952737
  -0.1%    -589  [ = ]       0    [900 Others]
  [DEL]    -646  [DEL]    -104    anon.884b1e16ac60104c4744bd22c43a82d6.31.llvm.11831773883379952737
  [DEL]    -793  [DEL]     -76    anon.0be5f78d782786092fb03f5ea0bcf0de.2.llvm.5482277008123388336
  -0.0%    -600  [ = ]       0    TOTAL

@Arpafaucon
Arpafaucon force-pushed the greg/smp-ci-reporting branch from 8948e88 to 45c414a Compare August 13, 2026 09:36
@pr-commenter

pr-commenter Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: d2d7ceed-ded8-4eab-a6c9-0502b79652e9
Baseline: b51122c5 · Comparison: beedf826 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_medium memory utilization ⚪ +0.14 metrics profiles logs
quality_gates_rss_dsd_low memory utilization ⚪ +0.12 metrics profiles logs
quality_gates_rss_idle memory utilization ⚪ +0.04 metrics profiles logs
quality_gates_rss_dsd_ultraheavy (erratic) memory utilization ⚪ -0.07 metrics profiles logs
quality_gates_rss_dsd_heavy (erratic) memory utilization ⚪ -0.08 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 231.34MiB ≤ 250MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 51.38MiB ≤ 60MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 89.50MiB ≤ 100MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 389.18MiB ≤ 420MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 33.99MiB ≤ 40MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression. Experiments tagged (no analysis) show ⚠️ n/a: SMP ran them but produced no analysis, usually because a replicate failed and exhausted its retries. Check the SMP report for that experiment's replicate failures.

@Arpafaucon

Copy link
Copy Markdown
Contributor Author

stack was merged on SMP side, aligning the local template on the current one
Screenshot 2026-09-30 at 18 57 43

Notable divergences so far

  • spaces between number and unit (I should be able to solve that one)
  • goal names are slightly longer as we reuse the official SMP labelling for those to limit duplication

@Arpafaucon
Arpafaucon force-pushed the greg/smp-ci-reporting branch from d570b7f to ac52243 Compare September 30, 2026 17:11
@Arpafaucon Arpafaucon added the changelog/no-changelog No changelog entry needed label Sep 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. changelog/no-changelog No changelog entry needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant