Skip to content

docs: Reposition around data engineering harness - #2399

Merged
ferenc-csaky merged 13 commits into
mainfrom
docs/harness-toolkit
Sep 29, 2026
Merged

ferenc-csaky merged 13 commits into
mainfrom
docs/harness-toolkit

Conversation

@mbroecheler

@mbroecheler mbroecheler commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

This implements the repositioning discussed in:
https://docs.google.com/document/d/17q5ooVeT73150bGJg-rWGvKsFuib8nwvaB2daz8WJAU

It is missing the elements listed under "Proposal". Those still need to be implemented.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs improvement — two user-facing documentation paths are broken.

[RISK ASSESSMENT]
MEDIUM: this documentation change affects first-run onboarding and the recovery link printed after a failed CLI test.

Verdict: COMMENT; address the two compatibility regressions before merging. Architectural insight: published documentation routes are public interfaces consumed by both readers and CLI output.

Improve this review? If feedback seems incorrect or irrelevant, update the repository's .agents/skills/custom-codereview-guide.md (with the /codereview trigger), then re-request review. The reviewer reads the guide from the PR head.

Resolve with AI? Install the iterate skill and run /iterate.

Was this review helpful? React with 👍 or 👎.

This review was generated by an AI agent (OpenHands) on behalf of the user.


Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/DataSQRL/sqrl/actions/runs/35935796951

Comment thread documentation/docs/intro/getting-started.md Outdated
Comment thread documentation/docs/howto/testing.md
@ferenc-csaky
ferenc-csaky force-pushed the docs/harness-toolkit branch 3 times, most recently from 2947fe6 to 1392981 Compare September 28, 2026 14:10
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.32%. Comparing base (9c1a8c0) to head (87cf0fa).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2399      +/-   ##
============================================
- Coverage     71.34%   71.32%   -0.02%     
  Complexity     1900     1900              
============================================
  Files           677      677              
  Lines         20356    20356              
  Branches       2553     2553              
============================================
- Hits          14522    14519       -3     
  Misses         4528     4528              
- Partials       1306     1309       +3     
Flag Coverage Δ
container-e2e 46.77% <ø> (-0.03%) ⬇️
integration 61.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky
ferenc-csaky merged commit a048bcf into main Sep 29, 2026
8 of 14 checks passed
@ferenc-csaky
ferenc-csaky deleted the docs/harness-toolkit branch September 29, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants