Repository navigation
Warnings and Workflows on feature branch (Quantization) - #38
Merged
Merged
Conversation
…our "remove those warnings" request). 2. .github/workflows/auto-assign.yml — the CI fix for the broken pozil/auto-assign-issue trigger.
…pre-existing and non-fatal): src/backend/CPUBackendT.cpp:87,109 had two raw static_cast<T>(dist(rng)) casts left over from the earlier hwy::float16_t portability pass — they compile fine on GCC/Linux (where float16_t apparently resolves to a native hardware type with an implicit float conversion) but fail outright on Clang/Windows (no matching conversion ... to 'hwy::float16_t', since there Highway falls back to its portable wrapper struct, which has no single-argument float constructor). Fixed both to use the established hwy::ConvertScalarTo<T> pattern already used everywhere else in this file. 2. Restrict optimization: added to ComputeError/ComputeErrorAndEnergy only — the one hand-rolled elementwise loop that runs unconditionally (no BLAS shortcut) for every call site, all verified to use three genuinely distinct buffers. Everything else either already has it (activation derivatives, via the existing ActivationDispatch.h function-pointer table), wouldn't benefit (BLAS-dispatched ops), or would be actively unsafe (MultiplyInto, which real code calls with aliased pointers in 4 different layers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update that will silence 3rd-party oneDNN errors and also an unnecessary workflow failure.