Skip to content

🎉 Add fix_available to KrakenDAudit - #13055

Merged
valentijnscholten merged 2 commits into
DefectDojo:bugfixfrom
manuel-sommer:krakend_fix_available
Sep 2, 2025
Merged

valentijnscholten merged 2 commits into
DefectDojo:bugfixfrom
manuel-sommer:krakend_fix_available

Conversation

@manuel-sommer

Copy link
Copy Markdown
Contributor

#12633 (comment)

I removed also the mitigation from dedeuplication as this was only there to close the old finding in case the mitigation becomes available.

@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR parser labels Aug 26, 2025
@dryrunsecurity

dryrunsecurity Bot commented Aug 26, 2025

Copy link
Copy Markdown

DryRun Security

This pull request contains a potential misinformation issue in the KrakenD audit report parser, where the code incorrectly hardcodes fix_available=True for all findings, which could mislead users about the actual remediation status of vulnerabilities.

Incorrect State Reporting / Misinformation in dojo/tools/krakend_audit/parser.py
Vulnerability Incorrect State Reporting / Misinformation
Description The code hardcodes fix_available=True for all findings parsed from KrakenD audit reports. This is problematic because it assumes a fix is always available, which is unlikely to be true for all security findings. This can mislead users about the true remediation status of vulnerabilities, potentially causing them to misprioritize remediation efforts or giving a false sense of security.

mitigation=message,
static_finding=True,
dynamic_finding=False,
fix_available=True,
)
findings.append(finding)
return findings


All finding details can be found in the DryRun Security Dashboard.

Comment thread dojo/settings/settings.dist.py
@github-actions github-actions Bot removed the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Aug 26, 2025
@manuel-sommer
manuel-sommer requested a review from Maffooch August 26, 2025 22:28
@valentijnscholten valentijnscholten added this to the 2.50.0 milestone Aug 27, 2025

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten valentijnscholten modified the milestones: 2.50.0, 2.50.1 Sep 2, 2025
@valentijnscholten
valentijnscholten merged commit 2a252ca into DefectDojo:bugfix Sep 2, 2025
86 checks passed
@manuel-sommer
manuel-sommer deleted the krakend_fix_available branch September 2, 2025 17:41
9alexx3 pushed a commit to 9alexx3/django-DefectDojo that referenced this pull request Aug 12, 2026
* 🎉 Add fix_available to KrakenDAudit

* Update settings.dist.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants