Conversation
…tion boundary Add two decisions to the OSS docs for the CloudResource location work. The endpoint migration guide now says the migration does not convert cloud resources held in Endpoint rows. Those rows keep migrating as URL Locations. A cloud connector re-import is the way to get a real Cloud Resource Location. The location drift matching guide now documents cloud resource matching. A cloud resource matches on its provider-assigned identifier alone, with no fuzzy matching.
Say what a user sees after the Pro change. Two findings on two different cloud resources are never duplicates. An earlier merge does not survive the next import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs only. Two pages get a short addition about cloud resource Locations (a DefectDojo Pro location type):
docs/content/asset_modelling/locations/PRO__migrating_from_endpoints.md: a new bullet under "What the Migration Does Not Do". Endpoints that hold cloud resource identifiers (ARNs and similar) migrate as URL Locations. They are not converted into Cloud Resource Locations. A cloud connector import is the way to model them.docs/content/triage_findings/finding_deduplication/PRO__location_drift_matching.md: a new "Cloud resource findings" section. Cloud resources match on their provider identifier only. Region, service, tags and display name do not take part in the match.Companion to a DefectDojo Pro change on the same release line (dev).
Test results
No code changed. I checked the Markdown renders and the headings sit under the existing sections.
Documentation
This PR is the documentation.