Repository navigation
Nightly: exempt only catalog/data/<key>_links.jsonl from the curated check - #100
Merged
Merged
Conversation
…check The curated-input check exempted fold outputs with fnmatchcase(path, "catalog/data/*_links.jsonl"), and fnmatch's * crosses "/", so the exemption also covered any curated input below catalog/data, such as a future catalog/data/external/<x>_links.jsonl. The fold writes only catalog/data/<key>_links.jsonl, one per frontier source key. The exemption now also requires no "/" after catalog/data/. The behavioural test adds a curated catalog/data/external/x_links.jsonl and expects a change to it to be listed; the pin test checks the new condition. Nothing matches differently today: catalog/data/tauceti_links.jsonl is the only curated *_links input.
The pattern itself still crosses /; the function is what restricts it.
Owner
Author
|
Recommendation: merge just before release B is rebuilt. It is release-affecting. An adversarial review found no defect, and CI is green (25 nightly tests).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The curated-input check (#83) exempts the fold's outputs with
fnmatchcase(path, "catalog/data/*_links.jsonl"). fnmatch's*crosses/, so the exemption also covered any curated input belowcatalog/data, such as a futurecatalog/data/external/<x>_links.jsonl. The fold writes onlycatalog/data/<key>_links.jsonl, one per frontier source key incatalog/data/source_registry.json. The exemption now also requires no/aftercatalog/data/(found in #83's re-review).Nothing matches differently today:
catalog/data/tauceti_links.jsonlis the only curated*_linksinput, and it stays exempt.Tests (
site/ops/test_brain_nightly.py)catalog/data/external/x_links.jsonland expects a change to it to be listed, next to the existingbot/statecases.I ran the changed snippet by hand:
tauceti_linksandfc_linksare exempt, whilecatalog/data/external/x_links.jsonlandbot/state/cut_log.jsonare checked.bash -npasses under bash and/bin/bash3.2. I didn't run the test suite locally because machine load was above the agreed limit; CI runs it.