Repository navigation
Attestation: drop the atlas assets until #85 merges - #104
Merged
Merged
Conversation
#82 attested assets/atlas.css and assets/atlas.js for release B, but they come from #85, which is not merged, and main's build-public does not produce them. A baseline freeze at main therefore fails ("missing assets/atlas.css, assets/atlas.js") or needs a tree built outside main. This drops those two entries, which restores the attestation #82's first commit (9726965) rendered with `brain_public_baseline.py attest` and trial-froze: the file is byte-identical to it (blob acd4b2d, 2,699 entries). The other attested sources still match main: assets/script.js, editor.js, style.css and review.css equal site/assets and wiki/assets. When #85 merges, it should re-attest the two atlas assets in the same PR.
Deicyde
added a commit
that referenced
this pull request
Oct 19, 2026
PR #104 dropped assets/atlas.css and assets/atlas.js from main's attestation until this PR merges, so release B could be built at 2cf36c7 without the atlas. This PR ships both files, so it restores both entries (atlas.css 044fbca9, atlas.js 29d8a77b): the files and their attestation land in one merge, and a release built from any later main freezes cleanly. Every other entry is main's, unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#82 attested
assets/atlas.cssandassets/atlas.jsfor release B. Those files come from #85, which is held for a demo, and main'swiki/scripts/build-public.tsdoesn't produce them.freezerequires the built public tree to match this inventory exactly (_require_attested_source), so a baseline freeze at main fails with "missing assets/atlas.css, assets/atlas.js", or passes only with a tree built outside main.Change
Drop those two entries. The file is now byte-identical to the attestation in #82's first commit (
9726965, blobacd4b2dc, 2,699 entries). That version was rendered withsite/ops/brain_public_baseline.py attest, and #82's body says a trialfreezepassed for it. In effect this reverts #82's second commit, "Attest the atlas assets for Brain release B".Checks
_canonical_json_bytes. That function reproduces the current file byte for byte, and the output passes_load_manifest_bytesand_validate_file_inventory.build-public.tscopies from source still match main exactly:assets/script.js,editor.js,style.cssandreview.css, againstsite/assets/*andwiki/assets/editor.js.freezechecks it at release time.When #85 merges
It should add the two atlas entries back in the same PR, for example by re-applying
0a09e9e0's change, so the attestation always matches what main builds.