Repository navigation
Conversation
From the re-reviews of #71 and #68: - brain-canary.yml's selector step made one attempt, so a single transient edge error failed the daily run, while the canary step itself rides out errors with --timeout 120. The probe now tries three times, 10 s apart, on a TransportError only; a 404 or an invalid selector still fails at once. - .gitattributes leaves NEUTRAL_FILES. It doesn't exist on main, but a committed one with eol or working-tree-encoding rules would change the bytes a fresh promotion worktree checks out for wiki/src while `git diff --name-only` showed only .gitattributes. The policy test lists it as release-affecting.
Owner
Author
|
Verdict: merge after release B is promoted. Nothing blocks merge. One static review, with each substantive finding checked by two refuters:
Notes (none blocks merge):
Posted by Claude Code (AutoformBot "Merge Currently Open PRs 4" session). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups from the re-reviews of #71 and #68. Release-neutral (
.github/andsite/ops/), so it can merge while release B is built.brain-canary.yml: retry the selector probe. The selector step made one attempt, so a single transient edge error failed the daily run, while the canary step after it already rides out errors with--timeout 120. The probe now tries three times, 10 s apart, and retries onlybrain_http.TransportError. A 404 or an invalid selector still fails at once..gitattributesis release-affecting. It leavesNEUTRAL_FILES. No such file exists on main. But a committed root.gitattributeswith eol or working-tree-encoding rules would change the bytes a fresh promotion worktree checks out forwiki/src, whilegit diff --name-onlyshowed only.gitattributesand the policy let it through. The policy test now lists it as release-affecting. No recordedneutral_changescan contain it, because the file has never existed.Checks: the workflow parses as YAML, and the selector's Python compiles. Under the changed policy
.gitattributesis affecting and.gitignoreis still neutral. This PR touches the workflow, so CI and the canary both run on it; the canary only reads production.