Repository navigation
Docs: the browser job is required - #73
Merged
Merged
Conversation
Since #72 the aggregate `required` job needs `worker`, `python` and `browser`, but CLAUDE.md, AGENTS.md and CONTRIBUTING.md still described the browser job as a non-required soak awaiting promotion. They now say it is required, and they note that its loopback server renders /brain with the `python3` on PATH, which must be 3.10 or newer for a local `npm run test:e2e`.
…owser Review fixes: - The e2e server imports site/build_brain_page.py and serves its HTML; it never runs the script. CLAUDE.md, AGENTS.md and CONTRIBUTING.md now say "importing". - brain/authority/README.md and site/ops/brain_activation_ci.py's docstring described the activation CI evidence as the (three) required CI commands. Since #72 required CI also includes the browser job, which the recorder does not run, so both now name the Worker and Python commands and say the browser job is not among them.
Owner
Author
|
Recommendation: merge. An independent adversarial review of
|
- The commands block's "Required, hermetic CI checks" heading lists only the Worker and Python commands; it now says the browser tests below are required too. - The Python 3.10 prerequisite moves from Security / credentials to the CI test boundaries Playwright bullet, and `required` is described as the hermetic Worker and Python gates plus the loopback-only browser gate (the browser job uses the runner's system python3 and apt packages). - "since #72" becomes "since PR #72"; bare issue numbers don't link in repository Markdown. - CONTRIBUTING.md: the Python sentence moves after "Linux CI uses ... to install system dependencies too", so "too" again means Chromium.
Owner
Author
|
Follow-up: polish applied in
The two files still match apart from line 1. All touched files remain release-neutral, and there is still no overlap with #74's hunk. |
Deicyde
added a commit
that referenced
this pull request
Oct 17, 2026
Docs: the browser job is required
Owner
Author
|
Re-review on main (
Minor: "required" doesn't bind admins ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #72, CI's aggregate
requiredjob needsworker,pythonandbrowser, but three docs still described the browser job as a non-required soak waiting for promotion.Changes
CLAUDE.mdandAGENTS.md(Security / credentials, CI test boundaries, commands block):requiredaggregates the hermeticworker,pythonandbrowsergates.CONTRIBUTING.md:workerandbrowseruse Node 22,pythonuses Python 3.12, andrequiredneeds all three./brainby importingsite/build_brain_page.pywith thepython3on PATH. Its imports need Python 3.10 or newer:brain/build_context.pyuses@dataclass(frozen=True, slots=True)(andbrain/stage_io.py@dataclass(slots=True)), andbuild_brain_page.pyevaluateslist[str] | Noneat definition time. Python 3.10 imports it and 3.9 fails. CI's browser job uses the runner's systempython3.brain/authority/README.mdandsite/ops/brain_activation_ci.py's docstring called that evidence "the (three) required CI commands". The recorder runsnpm ci,npm run test:ciandscripts/ci-python.sh, never the browser job, so both now say Worker and Python and note that the browser job is excluded. Whether activation evidence should attest the browser gate too is a separate decision: it would mean a schema change, and Playwright on the operator host.Not changed:
docs/ROADMAP.md:1080, a completed checklist entry that describes the CI of its time.Testing
Docs and one docstring; nothing executes these lines. They match
.github/workflows/ci.ymlon main (requiredhasneeds: [worker, python, browser]and checks all three results) and branch protection (it requires onlyrequired). Every touched file is release-neutral undersite/ops/brain_release_authority.py.