Skip to content

wiki: hono 4.12.34 -> 4.13.13 (security fixes) - #81

Closed
Deicyde wants to merge 1 commit into
mainfrom
claude/hono-4.13.13
Closed

Deicyde wants to merge 1 commit into
mainfrom
claude/hono-4.13.13

Conversation

@Deicyde

@Deicyde Deicyde commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Problem

npm audit of wiki/package-lock.json on main flags the Worker's runtime framework, hono 4.12.34 (vulnerable at or below 4.13.6):

  • GHSA-crvj-82cr-hjcx: the query parser reads parameters after the URL fragment, which causes cache-key and proxy interpretation differentials.
  • GHSA-g6gw-c38x-mqfc: unbounded dot-notation nesting in parseBody() can exhaust memory.
  • GHSA-gqvv-2mrq-wpjv: toSSG() can write outside its output directory.

The Worker doesn't use parseBody, toSSG or Hono's cache middleware, so only the query-parser fix plausibly applies here: the Worker parses query strings behind Cloudflare's proxy. It's still the runtime dependency, and the fix is a minor-version bump.

Change

  • hono 4.12.34 → 4.13.13, keeping the exact pin.
  • The package-lock.json change is limited to the root dependency and hono's own entry (version, tarball and integrity, which match the registry). @hono/node-server's peer range (^4) still holds.

How tested

  • Read the release notes for v4.13.0 through v4.13.13. They list no breaking changes: performance work in 4.13.0, the security fixes above, and deprecations (app.mount, hono/<adapter> imports) that still work in v4.
  • The Worker imports only hono and hono/cookie, and uses none of the APIs whose behavior changed (serveStatic, secureHeaders, parseBody, app.mount).
  • CI on this PR runs the full Worker, Python and browser suites.

Risks

  • 4.13.0 optimized the core request and response path. CI's full suites are the check.

Release

  • Release-affecting (per site/ops/brain_release_authority.py): wiki/package.json and wiki/package-lock.json. It ships only through a Brain release and promotion. Merge it before release B is built to include it there; otherwise it rides the next release.

What Jack must do

  • Nothing beyond the release.
  • Not included, each needing its own decision:
    • wrangler 4.151.1 fixes high advisories in miniflare, sharp and undici, but it is the promoter's deploy tool, so its timing relative to release B matters.
    • vitest 5 is a major upgrade that fixes the critical tinypool advisory in dev-only test tooling.
    • ajv 8.20.0 may change the generated companion validator.

Fixes GHSA-crvj-82cr-hjcx (the query parser read parameters after the URL fragment), GHSA-g6gw-c38x-mqfc (unbounded dot-notation nesting in parseBody) and GHSA-gqvv-2mrq-wpjv (toSSG path escape). The 4.13 release notes list no breaking changes. The Worker imports only hono and hono/cookie and uses none of the APIs whose behavior changed. The lockfile change is limited to hono's own entry.
@Deicyde

Deicyde commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner Author

Recommendation: close as superseded by #84 (updated). #84 moved main to hono 4.13.12, which already carries every published hono security fix (see the evidence above). 4.13.13 adds only the Mount Middleware and deprecates app.mount(), and the Worker uses neither. Dependabot (#80) can propose later versions on its own schedule.

Posted by the WikiLean PR swarm (lead); updated 2026-10-18.

@Deicyde

Deicyde commented Oct 18, 2026

Copy link
Copy Markdown
Owner Author

Recommendation: close as superseded by #84.

@Deicyde Deicyde closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant