Repository navigation
Re-review follow-ups: author-privilege tests, poller threshold, stale docs - #97
Merged
Merged
Conversation
… docs From the re-reviews of #57, #65, #68, #75 and #83 on main: - #57: the shared pull() fixture names the PR author again (Deicyde). With no author in it, the settle tests could not catch author privilege coming back: the declined carve-out passed every assertion. Two new tests pin the rest of the policy: the author's approve does not beat a non-maintainer's reject, and the author does not stand in for a maintainer in the gate. - #65: POLL_TIMEOUT_MINUTES goes from 25 to 55. With a 60-minute job limit, a cancelled run of 25 to 60 minutes is a dropped queued run or a manual cancel, never a timeout. The workflow comment's August numbers become 200 of 223 batch opens and 23 that got past the refresh (4.8-29.5 min), and it and the bot README's timeout bullet note that those runs used Git 2.54; the runner's Git 2.55 fetches a lazy clone's missing blobs in bulk. - #68/#75: the policy docstring no longer claims a new file is never silently neutral (a new file under a neutral directory is), and the Markdown comment names NEUTRAL_FILES. The inventory test also checks one sample name per repository path_pattern input, and the nightly-names test checks a sample child of each directory the nightly names. - #83: the operator docs say that a community-edge harvest, or running bot/brain_queue.py or brain/harvest_community_edges.py in the nightly's checkout, blocks Brain publishes until the change is committed; bot/.gitignore says build_cells.py reads pool_candidates.json; the runbook's neutral list notes the site/test_frontier_page.py exception.
…old wording - The workflow comment's counts: 200 of 224 batch opens were cancelled in the refresh; of the 24 that got past it, three were truncated refreshes (1.6-5.3 min) and the rest took 19.5-29.5 min, five then hitting the job limit. Run 31555154529 (found 7 tagged QIDs) was missing from the count. - The author-approve test also covers the author approving after the non-maintainer's reject, so "a later approve clears an objection" fails. - status.py's comment says a 55-60 minute cancel may still be a dropped or manual run; the test's timed-out runs now last 61-65 minutes. - bot/README: the nightly refuses only if the script actually changed the file.
Owner
Author
|
Recommendation: merge. An adversarial review of the first head found one inaccurate comment; it's fixed in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the re-reviews of #57, #65, #68, #75 and #83 (each PR's re-review comment has the evidence). Release-neutral: every touched file is neutral under
site/ops/brain_release_authority.py.Changes
pull()fixture (bot/test_poll.py). With no author, the declined carve-out passed every settle assertion. The fixture namesDeicydeagain.bot/test_settle_gate.pycover the rest of the owner's rule. The author's approve does not beat a non-maintainer's reject, whether it came before or after (the tag recycles). The author counts toward the two reviewers, but does not stand in for a maintainer (the gate stays closed).manage/status.pyPOLL_TIMEOUT_MINUTESgoes from 25 to 55. Run durations start atstartedAt, which includes queue time, so a cancelled run lasting 25 to 60 minutes is a dropped queued run or a manual cancel, not a timeout. The test's timed-out runs now last 61 to 65 minutes, with a 54.9-minute boundary.bot/README.md's timeout bullet now say those runs used Git 2.54. The runner's Git 2.55 fetches a lazy clone's missing blobs in bulk.NEUTRAL_FILES.path_patterninput (for examplesite/annotations/xx.json).wiki/,site/assets,brain/authority/schemas). Before, it couldn't fail for directory entries.site/ops/README.md,site/ops/nightly.local.env.exampleandbot/README.mdnow say that changing a curated input in the nightly's checkout blocks Brain publishes until it is committed. That covers a community-edge harvest and runningbot/brain_queue.pyorbrain/harvest_community_edges.py.bot/.gitignoresaysbrain/build_cells.pyreadspool_candidates.json.site/test_frontier_page.pyexception.Testing
CI runs every touched test file through
scripts/ci-python.sh. I didn't run them locally because machine load was above the agreed limit. I checked that every path-pattern sample is release-affecting under the current policy. This commit sits directly onmain(905c6def).