ASPNet: template compiler csp onetime detection#34478
Draft
vorobey wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a one-time (cached) capability check for Function constructor usage in the ASP.NET template compiler, to avoid repeatedly triggering CSP violations/exceptions during template compilation.
Changes:
- Introduced
canUseFunctionConstructor()with memoized result to detect whethernew Function(...)is permitted under the current CSP. - Updated template compilation to use
new Function(...)only when allowed; otherwise it immediately falls back to the existing script-based/global-eval path (or returns raw text for non-<script>templates).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.