Repository navigation
feat(maintenance): add fire-equipment park maintenance and resource management - #559
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 502bcbdefc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[ORM\Column(name: 'name', type: 'string', length: 160)] | ||
| public string $name; | ||
|
|
||
| #[ORM\Column(name: 'code', type: 'string', length: 64, nullable: true)] |
There was a problem hiding this comment.
Align supplier code storage with the accepted length
Supplier creation and update accept codes up to 80 characters (Supplier.php:82,165), but this mapping and the matching migration limit the column to 64 characters. A code between 65 and 80 characters therefore passes domain validation and then fails at PostgreSQL with a value-too-long error, which is not mapped by ProcurementExceptionSubscriber and surfaces as a 500. Increase the column to 80 or reduce the accepted limit to 64.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Context
FireGuard now supports the full fire-equipment park lifecycle: identify equipment, schedule independent controls and maintenance, retain execution evidence, repair or replace assets, and analyze internal maintenance costs. FireGuard branding remains unchanged.
Change Summary
Review Guide
Modules / Areas
Equipment, Facility, Maintenance, Inspection, Intervention, Organization and Onboarding; new Customer, ServiceRequest, Inventory, Procurement, MaintenanceCost and MaintenanceExport modules.
Main Files / Entry Points
Module contracts and
MODULE.mdfiles, explicit main-manager wiring inconfig/modules, API resources and DTOs, the canonicalopenapi.json, and twenty additive migrations undermigrations/main.Reviewer Focus
Functional Impact
Existing routes, equipment type codes, QR identities, historical campaigns and offline command identities are retained. A realized unfavorable control does not close its anomalies; creating work does not complete an occurrence. Published dossiers retain their original identity and evidence. Unknown historic cost attribution remains incomplete.
Risk And Rollback
Dedicated financial permissions protect costs and exports. Inventory facts survive shortage without negative stock or implicit partial debit. Return valuation restores exactly the remaining original value. Export corrections append compensating adjustments without rewriting retained artifacts.
Deploy using the existing development workflow, which backs up both databases and files before migration. An application rollback must use a compatible previously validated image; the additive schema is retained. Failed migrations require the documented coordinated recovery or a forward fix, not an automatic destructive schema rollback.
Validation
Local Validation
CI Validation
Deployment Notes
Use
developand the existing Deploy VPS workflow. Keepreset_development_fixtures=false. The twenty new migrations belong to main; preserve the workflow's auth-then-main ordering, backups, RBAC synchronization and transport initialization. New operation plans are prepared and activated explicitly; the release does not automatically switch an organization's preventive engine. Deploy API before the companion frontend, then verify workflow health checks.Known Gaps
Brand renaming, customer portal, cross-organization collaboration, sensors and a vendor-specific ERP connector remain deferred. General building and industrial maintenance remain outside scope.