Repository navigation
test(inspection): assert lookup associations independently of row order - #563
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
area:tests
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integrated develop CI failed when PostgreSQL returned the two correct inspection-to-equipment associations in the opposite order. The repository port promises a keyed lookup, and its sole production consumer accesses those values by key; the query does not promise row order.
Assert the exact entry count and each strict UUID association independently. Missing or extra keys, incorrect associations and wrong types still fail. Production queries and behavior are unchanged.
Validation: the actual PostgreSQL repository suite passes (6 tests, 18 assertions), scoped formatting and diff checks pass, and an independent read-only review confirms the assertions preserve the full map contract. The previous PR and develop commits have identical Git trees and ran the same 2,451-test integration suite; only the unsupported order assertion failed on develop.
Companion delivery: #562 and DevSkyLex/fireguard-web#310. This correction must pass fresh PR CI, then integrated develop CI and the unchanged Sonar gate before development deployment.