Repository navigation
refactor(maintenance): isolate plan mapping and share snapshot validation text - #564
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
area:tests
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current develop analysis still flags repeated target-snapshot error text and a Maintenance plan repository with 21 methods. Share the exact snapshot message in a private constant and move plan/occurrence storage conversion into a pure mapper. The repository retains SQL, organization scope, authority locks, transactions and its explicitly wired main connection.
All five mapping bodies are byte-for-byte identical to the analyzed commit. Historical values, nullable links, retry lineage, UTC storage and the frozen calendar timezone are preserved. The public constructor and HTTP contracts are unchanged. The repository now has 16 methods including its constructor; the mapper has five.
Validation: ServiceRequest Domain 107 tests/409 assertions; Maintenance unit 440/2,532, PostgreSQL repository 7/54 and HTTP 14/153; scoped style and PHPStan pass. Both Deptrac gates and container lint pass. Independent review retained no actionable regression. Fresh CI and integrated Sonar remain required before development deployment.
Confirmed Sonar findings: php:S1192 snapshot text, php:S1448 repository responsibility. No rule, profile, severity, exclusion, suppression or issue disposition was changed. Companion web: DevSkyLex/fireguard-web#310.