Repository navigation
fix(service-requests): preserve native confirmation status - #312
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The develop analysis after #311 leaves two generic null assertions and flags the explicit status role on the confirmed maintenance-request output. Simply removing that role makes the real HlmAlert host turn the result into an assertive alert.
Keep the Helm styling on a neutral presentation container and put the result in a native
<output hlmAlertDescription>. The output now supplies its own status semantics, with the same confirmation condition, text, translation ID and position outside the read-permission branch. The creator without READ retains confirmation without collection access or navigation. No global Helm primitive, permissions, stored data or API contract changes.Replace the two remaining Inventory
toBe(null)assertions with dedicatedtoBeNull()matchers, preserving selectors, commands and strict absence checks.Validation:
No Sonar disposition is added for the output diagnostic and no rule, severity, profile, exclusion or suppression changes.
Delivery verified:
43794244c28747171955e8fef5256329b2f8ea98: PR CI passed all 16 executed jobs, with only the expected PR Sonar skip.719c8e52c3aabd84ba89dfcb8dae0aabdaa93e0b, with an identical Git tree: develop CI passed all 17 jobs, including the actual Sonar scan and enforced gate. 9,177 tests / 792 files passed. Sonar reports zero new open or Accepted issues, 85.4% new-code coverage and 1.3% duplication.sha256:e8b07650456b90d59cef2ddc4411dcc5213561c90e11f5e5fb73641a08b7e7ac.