Skip to content

fix(service-requests): preserve native confirmation status - #312

Merged
DevSkyLex merged 2 commits into
developfrom
fix/maintenance-web-final-sonar
Oct 8, 2026
Merged

DevSkyLex merged 2 commits into
developfrom
fix/maintenance-web-final-sonar

Conversation

@DevSkyLex

@DevSkyLex DevSkyLex commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

The develop analysis after #311 leaves two generic null assertions and flags the explicit status role on the confirmed maintenance-request output. Simply removing that role makes the real HlmAlert host turn the result into an assertive alert.

Keep the Helm styling on a neutral presentation container and put the result in a native <output hlmAlertDescription>. The output now supplies its own status semantics, with the same confirmation condition, text, translation ID and position outside the read-permission branch. The creator without READ retains confirmation without collection access or navigation. No global Helm primitive, permissions, stored data or API contract changes.

Replace the two remaining Inventory toBe(null) assertions with dedicated toBeNull() matchers, preserving selectors, commands and strict absence checks.

Validation:

  • Inventory form suites: 21 tests / 2 files passed. Confirmation page: 14 tests passed.
  • Formatting, standard/type-aware lint, strict localized/SSR build, diff-scoped review and canonical Angular i18n extraction passed; the regenerated catalogue is byte-identical to develop.
  • Independent static reviews confirm equivalent Inventory assertions and valid native/Helm semantics with unchanged classes and permissions.
  • The real AOT host-role comparison passed 2/2: the previous explicit role produced status/polite, removal produced alert/assertive. Final real-page recapture passes 2/2 in Chromium and genuinely tactile Safari mobile: a single native OUTPUT status, no alert, exact Chromium live=polite/atomic=true; wrapper ignored. Helm classes and desktop geometry are unchanged; mobile remains inside its viewport. CREATE without READ remains covered. Evidence and limits: tests/e2e/artifacts/browser-regression/web-sonar-20261009/confirmation-wrapper/README.md.

No Sonar disposition is added for the output diagnostic and no rule, severity, profile, exclusion or suppression changes.

Delivery verified:

  • Final head 43794244c28747171955e8fef5256329b2f8ea98: PR CI passed all 16 executed jobs, with only the expected PR Sonar skip.
  • Integrated revision 719c8e52c3aabd84ba89dfcb8dae0aabdaa93e0b, with an identical Git tree: develop CI passed all 17 jobs, including the actual Sonar scan and enforced gate. 9,177 tests / 792 files passed. Sonar reports zero new open or Accepted issues, 85.4% new-code coverage and 1.3% duplication.
  • Docker publication and development deployment passed. The source revision, original CI run and OCI label were verified; deployed digest is sha256:e8b07650456b90d59cef2ddc4411dcc5213561c90e11f5e5fb73641a08b7e7ac.
  • Strict SSH host trust, healthy container and Ansible passed with zero failures. The public development gate requires 401 without credentials, then authenticated 200 and noindex. Additional HTTP clients on the operator workstation fail during TLS before any HTTP response; no local-access claim or TLS bypass is made.

@github-actions github-actions Bot added area:organization Organization or onboarding feature changes area:tests Unit, integration, or end-to-end test changes labels Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T23:20:24.884727Z ae0c206 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added size:xs Small PR: under 50 changed lines state:ready Ready for review labels Oct 8, 2026
@DevSkyLex DevSkyLex changed the title test(inventory): use dedicated null matchers fix(service-requests): preserve native confirmation status Oct 8, 2026
@DevSkyLex
DevSkyLex merged commit 719c8e5 into develop Oct 8, 2026
20 checks passed
@DevSkyLex
DevSkyLex deleted the fix/maintenance-web-final-sonar branch October 9, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:organization Organization or onboarding feature changes area:tests Unit, integration, or end-to-end test changes size:xs Small PR: under 50 changed lines state:ready Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant