Skip to content

fix(maintenance): harden scope changes and expand workflow coverage - #313

Merged
DevSkyLex merged 3 commits into
developfrom
fix/frontend-overall-quality
Oct 9, 2026
Merged

DevSkyLex merged 3 commits into
developfrom
fix/frontend-overall-quality

Conversation

@DevSkyLex

@DevSkyLex DevSkyLex commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Resolve the three remaining historic Sonar maintainability findings and extend executable coverage of customer, procurement, maintenance-plan and maintenance-export workflows.

The added regressions also exposed three runtime problems. Clearing a purchase selection now cancels its outstanding detail/history reads. Maintenance-plan reads and feedback belong to an organization visit, while accepted writes finish and retain admission across a return to that organization. Uncertain export retries check the retained command's permission, and a revoked confirmation grant no longer changes confirmation into adjustment.

The intervention workspace groups its offline execution dependencies without changing injection order, and the intervention-page setup hooks precede their tests. API contracts, coverage exclusions, Sonar rules and quality thresholds are unchanged.

Validation:

  • 9,393 Angular tests pass across 794 files; local coverage is 93.76% lines and 84.63% branches.
  • Full lint, type-aware lint and 75 architecture checks pass.
  • Formatting, documentation on the six authored sources, structural review and E2E TypeScript contracts pass.
  • Strict EN/FR/ES SSR build and 13 hermetic desktop/mobile browser scenarios pass, including light/dark touch flows and exact response-loss recovery.
  • Five bounded independent static reviews are complete. Their one test-context finding was corrected, confirmed closed and validated by the 21 list tests.
  • The generated source catalog is synchronized; a strict comparison confirms that only 26 source-line references changed.
  • Final integrated develop analysis, including the dependency-default correction in fix(interventions): apply offline dependency defaults individually #314, confirms zero open maintainability issues and 90.4% overall Sonar coverage on 003fdcc. CI: 17/17 jobs succeeded. Dev deployment succeeded with the same source revision and immutable image digest.

@github-actions github-actions Bot added area:organization Organization or onboarding feature changes area:intervention Intervention workflow or offline mode changes area:tests Unit, integration, or end-to-end test changes area:docs Documentation changes risk:api-contract API contract, model, or data-access risk size:xl Very large PR: 800 changed lines or more state:draft Draft pull request labels Oct 9, 2026
@github-actions github-actions Bot added the area:i18n Translation catalog changes label Oct 9, 2026
@DevSkyLex
DevSkyLex marked this pull request as ready for review October 9, 2026 08:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T08:19:23.060960Z c7bedc7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added state:ready Ready for review and removed state:draft Draft pull request labels Oct 9, 2026
@DevSkyLex
DevSkyLex merged commit 7448867 into develop Oct 9, 2026
35 of 37 checks passed
@DevSkyLex
DevSkyLex deleted the fix/frontend-overall-quality branch October 11, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentation changes area:i18n Translation catalog changes area:intervention Intervention workflow or offline mode changes area:organization Organization or onboarding feature changes area:tests Unit, integration, or end-to-end test changes risk:api-contract API contract, model, or data-access risk size:xl Very large PR: 800 changed lines or more state:ready Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant