Repository navigation
fix(maintenance): harden scope changes and expand workflow coverage - #313
Merged
Merged
Conversation
DevSkyLex
marked this pull request as ready for review
October 9, 2026 08:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the three remaining historic Sonar maintainability findings and extend executable coverage of customer, procurement, maintenance-plan and maintenance-export workflows.
The added regressions also exposed three runtime problems. Clearing a purchase selection now cancels its outstanding detail/history reads. Maintenance-plan reads and feedback belong to an organization visit, while accepted writes finish and retain admission across a return to that organization. Uncertain export retries check the retained command's permission, and a revoked confirmation grant no longer changes confirmation into adjustment.
The intervention workspace groups its offline execution dependencies without changing injection order, and the intervention-page setup hooks precede their tests. API contracts, coverage exclusions, Sonar rules and quality thresholds are unchanged.
Validation: