test(extra): centralize mstsgu integration tests - #1743
Open
Benoît Cortier (CBenoit) wants to merge 10 commits into
Open
test(extra): centralize mstsgu integration tests#1743Benoît Cortier (CBenoit) wants to merge 10 commits into
Benoît Cortier (CBenoit) wants to merge 10 commits into
Conversation
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 08:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates MSTSGU integration tests into one binary to reduce relinking while retaining native-TLS coverage.
Changes:
- Registers a unified integration-test harness.
- Moves native-TLS gating to the
http_authmodule. - Updates xtask commands for the new target.
No material findings identified; protocol review was unnecessary because protocol behavior is unchanged.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
xtask/src/check.rs |
Targets the consolidated test binary. |
crates/ironrdp-mstsgu/Cargo.toml |
Disables test autodiscovery and registers one harness. |
crates/ironrdp-mstsgu/tests/main.rs |
Declares the test modules and feature gate. |
crates/ironrdp-mstsgu/tests/http_auth.rs |
Removes the now-centralized lint allowance. |
crates/ironrdp-mstsgu/tests/http_control.rs |
Removes the now-centralized lint allowance. |
crates/ironrdp-mstsgu/tests/rpc_pdu.rs |
Removes the now-centralized lint allowance. |
crates/ironrdp-mstsgu/tests/udp.rs |
Removes the now-centralized lint allowance. |
github-actions
Bot
added
maintainer-required
Benoît Cortier (CBenoit)
changed the title
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 08:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 09:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 21, 2026 10:49
ecbf2a1 to
07910d5
Compare
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 10:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 21, 2026 20:16
07910d5 to
6b9742a
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 21, 2026 20:16 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 21, 2026 20:25
6b9742a to
bdf4a10
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 21, 2026 20:26 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 22, 2026 07:23
bdf4a10 to
f9f7a02
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 22, 2026 07:24 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
risk/unknown
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 22, 2026 07:41 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 23, 2026 07:25
c8c0389 to
569972a
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 23, 2026 07:25 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 26, 2026 15:09
569972a to
080a5a7
Compare
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 27, 2026
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 28, 2026 15:03
080a5a7 to
d57abdc
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 28, 2026 15:03 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 28, 2026 16:46 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
the
size/L
github-actions
Bot
removed
the
size/M
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 28, 2026 18:00 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 28, 2026 18:32
c4d254c to
e5f7285
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 28, 2026 18:33 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 29, 2026 03:28
e5f7285 to
ddc3f56
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 29, 2026 03:29 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 29, 2026 15:12
ddc3f56 to
26a5e17
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 29, 2026 15:12 — with
GitHub Actions
Active
GitHub Actions
Active
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 29, 2026 15:17
26a5e17 to
5e4673f
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 29, 2026 15:18 — with
GitHub Actions
Active
GitHub Actions
Active
Use one test harness to preserve feature-gated coverage while avoiding repeated relinking. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move Mstsgu coverage to the shared extra test harness. Keep native-TLS coverage in the same centralized binary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Nest the Mstsgu integration modules beneath the extra test harness. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain upstream Mstsgu coverage in the centralized harness after rebasing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep native TLS smart-card coverage in the extra test harness. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the Mstsgu integration coverage to the extra suite's sole test binary. This leaves ironrdp-mstsgu with no Cargo test targets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The crate has no test targets, so this import no longer has a supporting dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep Mstsgu integration coverage in the extra-suite harness so the package exposes no Cargo test target. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the updated RPCH v2 coverage in the extra-suite harness. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep RPC stub coverage in the extra-suite harness with its test-only dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-mstsgu-tests
branch
from
August 30, 2026 02:55
5e4673f to
177eff0
Compare
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 30, 2026 02:55 — with
GitHub Actions
Active
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Mstsgu coverage to the shared extra test harness.
Keep native-TLS coverage in the same centralized binary.