fix(pdu): clamp wheel rotation to valid range - #1817
Closed
Mariusz Białończyk (manio) wants to merge 1 commit into
Closed
fix(pdu): clamp wheel rotation to valid range#1817Mariusz Białończyk (manio) wants to merge 1 commit into
Mariusz Białończyk (manio) wants to merge 1 commit into
Conversation
MousePdu::encode asserted that number_of_wheel_rotation_units fits the wire's 9-bit two's-complement range ([-256, 255]) and panicked via debug_assert! otherwise. Database::apply in ironrdp-input forwards the OS-reported wheel delta into this field unclamped, so a fast scroll (delta beyond that range, e.g. -300) panicked any debug build. Clamp to [-256, 255] in encode instead of asserting, so the encoder can no longer panic regardless of what a caller passes in. Values outside the range now saturate to the nearest representable edge rather than being rejected. Fixes: Devolutions#1816
Mariusz Białończyk (manio)
deployed
to
llm-providers
August 28, 2026 14:36 — with 
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
maintainer-required
Closed
Contributor
|
can you see if this PR still makes sense after merging #1818 for the same issue? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MousePdu::encode asserted that number_of_wheel_rotation_units fits the wire's 9-bit two's-complement range ([-256, 255]) and panicked via debug_assert! otherwise. Database::apply in ironrdp-input forwards the OS-reported wheel delta into this field unclamped, so a fast scroll (delta beyond that range, e.g. -300) panicked any debug build.
Clamp to [-256, 255] in encode instead of asserting, so the encoder can no longer panic regardless of what a caller passes in. Values outside the range now saturate to the nearest representable edge rather than being rejected.
Fixes: #1816