Skip to content

fix(mstsgu): default gateway port to HTTPS - #1823

Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 2 commits into
masterfrom
copilot/gateway-default-port
Open

fix(mstsgu): default gateway port to HTTPS#1823
Marc-André Moreau (mamoreau-devolutions) wants to merge 2 commits into
masterfrom
copilot/gateway-default-port

Conversation

@mamoreau-devolutions

Copy link
Copy Markdown
Contributor

Accept host-only gateway endpoints as HTTPS authorities and connect to port 443. Explicit ports and bracketed IPv6 literals retain their normalized endpoints.

Copilot AI balanced review requested due to automatic review settings August 28, 2026 21:25
@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Defaults host-only RD Gateway endpoints to HTTPS port 443 while preserving explicit ports and IPv6 formatting.

Changes:

  • Parses and normalizes gateway authorities.
  • Adds endpoint validation and normalization tests.
  • Documents optional gateway ports.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/packet_io.rs Implements endpoint parsing and default port handling.
src/test_support.rs Exposes normalization for tests.
tests/proxy.rs Tests valid and malformed endpoints.
src/lib.rs Documents endpoint syntax.

Comment thread crates/ironrdp-mstsgu/src/packet_io.rs
Accept host-only gateway endpoints as HTTPS authorities and connect to port 443. Explicit ports and bracketed IPv6 literals retain their normalized endpoints.
Reject userinfo in gateway endpoints before parsing their authority so malformed targets cannot select an unintended host.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure

Development

Successfully merging this pull request may close these issues.

2 participants