feat(mstsgu): add unprotected RPC call framing - #1829
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Open
feat(mstsgu): add unprotected RPC call framing#1829Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Marc-André Moreau (mamoreau-devolutions) wants to merge 3 commits into
Conversation
Add unprotected bind negotiation and request fragmentation. Use context-aware response and fault decoding with existing reassembly. Keep authentication, signing, and TsProxy payloads out of this layer.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 00:33 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 29, 2026 00:33
View session
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unauthenticated DCE/RPC bind negotiation, request fragmentation, and negotiated-context response decoding to MSTSGU framing.
Changes:
- Adds bind ACK/NAK codecs and presentation-context types.
- Fragments unprotected requests using negotiated limits.
- Adds context-aware response/fault decoding and tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/rpc.rs |
Implements RPC negotiation and framing. |
crates/ironrdp-mstsgu/tests/rpc_pdu.rs |
Tests new wire codecs. |
crates/ironrdp-mstsgu/Cargo.toml |
Marks uuid as public. |
Preserve expected presentation contexts in mismatch errors and clarify bind_nak length diagnostics. Cover directional bind_ack fragment maximum negotiation.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 02:08 — with
GitHub Actions
Active
GitHub Actions
Active
Use the daemon output-channel wrapper so the tests exercise the\nsame must-deliver event semantics as production and compile against\nconsume_output's receiver type.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 13:26 — with
GitHub Actions
Active
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unprotected bind negotiation and request fragmentation.
Use context-aware response and fault decoding with existing reassembly.
Keep authentication, signing, and TsProxy payloads out of this layer.