feat(mstsgu): add RPCH v2 channel recycling - #1831
Merged
Marc-André Moreau (mamoreau-devolutions) merged 3 commits intoAug 29, 2026
Merged
feat(mstsgu): add RPCH v2 channel recycling#1831Marc-André Moreau (mamoreau-devolutions) merged 3 commits into
Marc-André Moreau (mamoreau-devolutions) merged 3 commits into
Conversation
Add wire codecs and ordering validation for v2 R1 recycling. Keep transport handoff separate; protocol errors terminate recycle state.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 00:34 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 29, 2026 00:34
View session
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RPCH v2 R1 channel-recycling codecs and state validation to the MSTSGU protocol implementation.
Changes:
- Adds IN/OUT recycling PDU codecs.
- Adds recycling state machines and protocol-error handling.
- Adds exact wire-vector and ordering tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/rpc.rs |
Implements recycling codecs and state transitions. |
crates/ironrdp-mstsgu/tests/rpch_v2.rs |
Tests wire encoding, state updates, and invalid ordering. |
Preserve updated cookies, flow-control state, and ping timeouts across recycling.\n\nKeep channels pending until their final RTS PDUs are sent.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 02:10 — with
GitHub Actions
Active
GitHub Actions
Active
Use the output channel wrapper required by consume_output in error-status tests.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 13:17 — with
GitHub Actions
Active
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
merged commit Aug 29, 2026
35152e6
into
master
43 of 60 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/rpch-channel-recycling
branch
August 29, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wire codecs and ordering validation for v2 R1 recycling.
Retain canonical recycle state and reopen channels only after the final RTS action is sent. Keep transport execution separate, and use the typed output test channel required for workspace test compilation.