fix(daemon): construct test output channels via output_channel() - #1832
Closed
Greg Lamberson (glamberson) wants to merge 1 commit into
Closed
Conversation
Greg Lamberson (glamberson)
deployed
to
llm-providers
August 29, 2026 00:36 — with
GitHub Actions
Active
Contributor
Author
|
Superseded by #1827, which includes this exact fix (same two-line change, mpsc::channel(1) to output_channel(1) at both call sites) as part of its larger scope. Closing in favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo check -p ironrdp-daemon --testscurrently fails on baremasterwith twoE0308errors atdaemon.rs:2239and:2276:expected OutputEventReceiver, found tokio::sync::mpsc::Receiver<_>.connection_failure_status_preserves_gateway_error_sourcesandterminated_error_status_preserves_session_error_sources(added by #1822,merged after #1815 changed
consume_output's parameter type) constructoutput_rxvia the pre-#1815mpsc::channel(1)pattern. Every other call sitein this file, five of them, already uses #1815's
output_channel(1)constructor; these two were missed. Swaps both to match.
No behavior change:
output_channel(1)still yields an(OutputEventSender, OutputEventReceiver)pair consumed identically by bothtests, both of which construct a
MustDeliver-classified event(
ConnectionFailure,Terminated), unaffected by the drop-policy routing#1815 introduced.