feat(mstsgu): add RPC integrity framing - #1839
feat(mstsgu): add RPC integrity framing#1839Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
Conversation
|
This pull request is Please split it into focused pull requests that can each be reviewed on their own. When the parts build on each other, stacked pull requests let you open each one on top of the last without waiting for the one below to merge. Stacks require every branch to live in this repository, so from a fork, please open separate pull requests instead. Automated review resumes once the change is below the |
There was a problem hiding this comment.
Pull request overview
Adds caller-managed DCE/RPC packet-integrity framing to the MSTSGU codec layer.
Changes:
- Adds authenticated PDU preparation, decoding, and response reassembly.
- Adds validation and comprehensive framing tests.
- Updates crate capability documentation.
Review scope: prose-verifier was skipped because the prose change is a single factual list item.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/rpc.rs |
Implements integrity framing and authenticated reassembly. |
crates/ironrdp-mstsgu/tests/rpc_pdu.rs |
Tests authenticated framing, validation, and recovery. |
crates/ironrdp-mstsgu/README.md |
Documents packet-integrity support. |
Provide structural packet-integrity DCE/RPC framing with explicit caller-owned signed regions and verifier validation. Reject unsupported authentication levels and clear terminal response state after failed decoding. Verifier construction, sequence ownership, and RPCH transport remain with a future security context.
9427c8e to
f4f4415
Compare
db6436e
into
master
Provide structural packet-integrity DCE/RPC framing with explicit caller-owned signed regions and verifier validation.
Reject unsupported authentication levels and clear terminal response state after failed decoding. Verifier construction, sequence ownership, and RPCH transport remain with a future security context.