Skip to content

feat(mstsgu): add RPC integrity framing - #1839

Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
masterfrom
copilot/rpc-integrity-framing
Aug 30, 2026
Merged

feat(mstsgu): add RPC integrity framing#1839
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
masterfrom
copilot/rpc-integrity-framing

Conversation

@mamoreau-devolutions

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Provide structural packet-integrity DCE/RPC framing with explicit caller-owned signed regions and verifier validation.

Reject unsupported authentication levels and clear terminal response state after failed decoding. Verifier construction, sequence ownership, and RPCH transport remain with a future security context.

Copilot AI balanced review requested due to automatic review settings August 29, 2026 23:50
@github-actions github-actions Bot added maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny size/XXL Size: 1300 or more counted lines or 50 or more files labels Aug 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is size/XXL, so automated review is disabled for it: a change this large is hard to review well in one piece, whether by a human or a model.

Please split it into focused pull requests that can each be reviewed on their own. When the parts build on each other, stacked pull requests let you open each one on top of the last without waiting for the one below to merge. Stacks require every branch to live in this repository, so from a fork, please open separate pull requests instead.

Automated review resumes once the change is below the size/XXL threshold.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds caller-managed DCE/RPC packet-integrity framing to the MSTSGU codec layer.

Changes:

  • Adds authenticated PDU preparation, decoding, and response reassembly.
  • Adds validation and comprehensive framing tests.
  • Updates crate capability documentation.

Review scope: prose-verifier was skipped because the prose change is a single factual list item.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/ironrdp-mstsgu/src/rpc.rs Implements integrity framing and authenticated reassembly.
crates/ironrdp-mstsgu/tests/rpc_pdu.rs Tests authenticated framing, validation, and recovery.
crates/ironrdp-mstsgu/README.md Documents packet-integrity support.

Comment thread crates/ironrdp-mstsgu/src/rpc.rs Outdated
Comment thread crates/ironrdp-mstsgu/src/rpc.rs Outdated
Provide structural packet-integrity DCE/RPC framing with explicit caller-owned signed regions and verifier validation.

Reject unsupported authentication levels and clear terminal response state after failed decoding. Verifier construction, sequence ownership, and RPCH transport remain with a future security context.
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit db6436e into master Aug 30, 2026
43 checks passed
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) deleted the copilot/rpc-integrity-framing branch August 30, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-required Maintainer review or intervention is required risk/unknown Risk could not be determined automatically; needs maintainer-level scrutiny size/XXL Size: 1300 or more counted lines or 50 or more files

Development

Successfully merging this pull request may close these issues.

2 participants