fix(mstsgu): accept advertised extended auth - #1841
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoAug 30, 2026
Merged
Conversation
Treat handshake ExtendedAuth bits as capabilities after HTTP authentication. Require SSPI_NTLM and run its exchange when selected at transport setup.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 30, 2026 00:22 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 30, 2026 00:22
View session
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MS-TSGU handshake handling so advertised extended-authentication capabilities do not reject ordinary HTTP-authenticated sessions.
Changes:
- Ignores unselected extended-authentication capabilities.
- Tests capability preservation and SSPI_NTLM negotiation requirements.
- Clarifies unsupported authentication modes in the README.
No findings identified. Dedicated compression and prose-verification passes were skipped due to the five-skill limit; equivalent checks were applied directly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/lib.rs |
Accepts advertised capabilities unless SSPI_NTLM was selected. |
crates/ironrdp-mstsgu/tests/consent.rs |
Covers HTTP and SSPI_NTLM negotiation behavior. |
crates/ironrdp-mstsgu/tests/http_control.rs |
Tests preservation of capability bit combinations. |
crates/ironrdp-mstsgu/README.md |
Clarifies unsupported extended-authentication exchanges. |
Marc-André Moreau (mamoreau-devolutions)
merged commit Aug 30, 2026
c4533fe
into
master
44 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
copilot/gateway-extended-auth-negotiation
branch
August 30, 2026 02:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat handshake ExtendedAuth bits as capabilities after HTTP authentication.
Require SSPI_NTLM and run its exchange when selected at transport setup.