Skip to content

Move package-list action bar items to overflow flyout - #5363

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/actionbar-overflow-menu
Sep 9, 2026
Merged

Move package-list action bar items to overflow flyout#5363
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/actionbar-overflow-menu

Conversation

@GabrielDuf

Copy link
Copy Markdown
Contributor

This pull request introduces a responsive, overflow-aware toolbar for the packages page, replacing the previous static horizontal toolbar. The new implementation ensures toolbar buttons remain accessible on narrow windows by collapsing labels and moving excess buttons into an overflow menu. Major changes involve both the ViewModel and View, including a new ToolbarOverflowPanel control, a new ToolbarEntry abstraction, and logic to manage overflowed items.

Toolbar Responsiveness and Overflow Handling:

  • Added a new ToolbarOverflowPanel control (ToolbarOverflowPanel.cs) that dynamically arranges toolbar items, collapses labels when space is limited, and moves items into an overflow menu as needed.
  • Updated the toolbar in the view (AbstractPackagesPage.axaml and .axaml.cs) to use ToolbarOverflowPanel, added an overflow button, and implemented logic to populate the overflow menu with hidden toolbar items.

ViewModel Adjustments:

  • Introduced a new ToolbarEntry record to represent toolbar items, replacing the previous use of ToolBarItems with a strongly-typed ToolbarEntries list.
  • Updated toolbar button and separator creation methods to use ToolbarEntry and the new list.

Code Cleanup and Refactoring:

  • Removed old responsive toolbar code that collapsed labels based on window width, now handled by the new panel and its callbacks.
  • Cleaned up toolbar button definitions in SoftwareUpdatesPage.cs for consistency with the new system.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The refactor unintentionally removes bulk and management actions for automatic updates.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Introduces a responsive package-page toolbar that collapses labels and moves excess actions into an overflow flyout.

Changes:

  • Adds ToolbarOverflowPanel and overflow-menu population.
  • Replaces untyped toolbar items with ToolbarEntry.
  • Removes two automatic-update toolbar actions.
File summaries
File Description
SoftwareUpdatesPage.cs Updates action definitions and removes automatic-update actions.
AbstractPackagesPage.axaml.cs Initializes and populates the overflow flyout.
AbstractPackagesPage.axaml Replaces the toolbar with the overflow panel.
ToolbarOverflowPanel.cs Implements responsive measurement and overflow behavior.
PackagesPageViewModel.cs Introduces typed toolbar entries.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareUpdatesPage.cs

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "cb8ec330-ac53-11f1-93e0-292297242400",
	"headSha": "0e67540b0e08a1bbd3cb397c100fd14e5af2a370",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 7190549 into main Sep 9, 2026
6 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the fix/actionbar-overflow-menu branch September 9, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants