Skip to content

Allow updating a package from the installed packages list #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into from
Sep 9, 2026
+48 −51
Merged

Allow updating a package from the installed packages list #5366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Languages/lang_en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,6 @@
"Manage the list": "Manage the list",
"Automatically update selected packages": "Automatically update selected packages",
"Manage automatic updates": "Manage automatic updates",
"Update this package automatically": "Update this package automatically",
"{0} package(s) marked for automatic updates": "{0} package(s) marked for automatic updates",
"Turn on \"Install available updates\" in the scheduled maintenance settings for this to take effect.": "Turn on \"Install available updates\" in the scheduled maintenance settings for this to take effect.",
"Every upgradable package is already installed automatically, so this changes nothing until the scheduled task is limited to marked packages.": "Every upgradable package is already installed automatically, so this changes nothing until the scheduled task is limited to marked packages.",
Expand Down
48 changes: 47 additions & 1 deletion src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ public class InstalledPackagesPage : AbstractPackagesPage
private MenuItem? _menuOpenInstallLocation;
private MenuItem? _menuDownloadInstaller;
private MenuItem? _menuManual;
private MenuItem? _menuUpdate;
private MenuItem? _menuUpdateAsAdmin;

private static bool _hasBackedUp;

Expand Down Expand Up @@ -183,6 +185,21 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)
};
_menuRemoveData.Click += (_, _) => _ = LaunchUninstall([SelectedItem!], remove_data: true);

_menuUpdate = new MenuItem
{
Header = CoreTools.Translate("Update"),
Icon = LoadMenuIcon("update"),
};
_menuUpdate.Click += (_, _) => _ = LaunchUpdate(SelectedItem);

_menuUpdateAsAdmin = new MenuItem
{
Header = CoreTools.Translate("Update as administrator"),
Icon = LoadMenuIcon("uac"),
IsVisible = OperatingSystem.IsWindows(),
};
_menuUpdateAsAdmin.Click += (_, _) => _ = LaunchUpdate(SelectedItem, elevated: true);

_menuDownloadInstaller = new MenuItem
{
Header = CoreTools.Translate("Download installer"),
Expand Down Expand Up @@ -230,6 +247,9 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)
menu.Items.Add(_menuInteractive);
menu.Items.Add(_menuRemoveData);
menu.Items.Add(new Separator());
menu.Items.Add(_menuUpdate);
menu.Items.Add(_menuUpdateAsAdmin);
menu.Items.Add(new Separator());
menu.Items.Add(_menuDownloadInstaller);
menu.Items.Add(new Separator());
menu.Items.Add(_menuReinstall);
Expand All @@ -244,7 +264,8 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)

protected override void WhenShowingContextMenu(IPackage package)
{
if (_menuAsAdmin is null || _menuInteractive is null || _menuRemoveData is null
if (_menuUpdate is null || _menuUpdateAsAdmin is null
|| _menuAsAdmin is null || _menuInteractive is null || _menuRemoveData is null
|| _menuInstallationOptions is null || _menuReinstall is null
|| _menuUninstallThenReinstall is null || _menuIgnoreUpdates is null
|| _menuDetails is null
Expand All @@ -262,6 +283,17 @@ protected override void WhenShowingContextMenu(IPackage package)
_menuAsAdmin.IsEnabled = caps.CanRunAsAdmin;
_menuInteractive.IsEnabled = caps.CanRunInteractively;
_menuRemoveData.IsEnabled = caps.CanRemoveDataOnUninstall;

// The installed entry knows no target version; its upgradable counterpart does,
// and is null whenever no update is pending for the package.
var upgradable = package.GetUpgradablePackage();
bool canUpdate = upgradable is not null;
_menuUpdate.IsEnabled = canUpdate;
_menuUpdate.Header = upgradable is null
? CoreTools.Translate("Update")
: CoreTools.Translate("Update to version {0}", upgradable.NewVersionString);
_menuUpdateAsAdmin.IsEnabled = canUpdate && caps.CanRunAsAdmin;

_menuDownloadInstaller.IsEnabled = !isLocal && caps.CanDownloadInstaller;
_menuInstallationOptions.IsEnabled = !isLocal;
_menuReinstall.IsEnabled = !isLocal;
Expand Down Expand Up @@ -373,6 +405,20 @@ private static async Task LaunchUninstall(
}
}

private static async Task LaunchUpdate(IPackage? package, bool? elevated = null)
{
// Updates must run on the upgradable instance: the installed one reports
// NewVersionString == VersionString, which managers read as "nothing to do".
if (package?.GetUpgradablePackage() is not { } upgradable) return;
var opts = await InstallOptionsFactory.LoadApplicableAsync(upgradable, elevated: elevated);
if (PackageOperation.HasPendingOperation(upgradable, OperationType.Update)) return;
var op = new UpdatePackageOperation(upgradable, opts);
op.OperationSucceeded += (_, _) => TelemetryHandler.UpdatePackage(upgradable, TEL_OP_RESULT.SUCCESS);
op.OperationFailed += (_, _) => TelemetryHandler.UpdatePackage(upgradable, TEL_OP_RESULT.FAILED);
AvaloniaOperationRegistry.Add(op);
_ = op.MainThread();
}

private static async Task LaunchReinstall(IPackage? package)
{
if (package is null || package.Source.IsVirtualManager) return;
Expand Down
50 changes: 1 addition & 49 deletions src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareUpdatesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ public class SoftwareUpdatesPage : AbstractPackagesPage
private MenuItem? _menuSkipHash;
private MenuItem? _menuDownloadInstaller;
private MenuItem? _menuOpenInstallLocation;
private MenuItem? _menuAutoUpdate;

public SoftwareUpdatesPage() : base(new PackagesPageData
{
Expand Down Expand Up @@ -198,23 +197,6 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)
UpgradablePackagesLoader.Instance.IgnoredPackages[pkg.Id] = pkg;
};

_menuAutoUpdate = new MenuItem
{
Header = CoreTools.Translate("Update this package automatically"),
Icon = LoadMenuIcon("sandclock"),
ToggleType = MenuItemToggleType.CheckBox,
};
_menuAutoUpdate.Click += (_, _) =>
{
var pkg = SelectedItem;
if (pkg is null) return;
string id = AutoUpdatesDatabase.GetIdForPackage(pkg);
if (AutoUpdatesDatabase.IsAutoUpdated(id))
AutoUpdatesDatabase.Remove(id);
else
MarkForAutoUpdates([pkg]);
};

var menuSkipVersion = new MenuItem
{
Header = CoreTools.Translate("Skip this version"),
Expand Down Expand Up @@ -282,8 +264,6 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)
menu.Items.Add(menuUninstallThenUpdate);
menu.Items.Add(menuUninstall);
menu.Items.Add(new Separator());
menu.Items.Add(_menuAutoUpdate);
menu.Items.Add(new Separator());
menu.Items.Add(menuIgnore);
menu.Items.Add(menuSkipVersion);
menu.Items.Add(menuPause);
Expand All @@ -296,8 +276,7 @@ protected override void GenerateToolBar(PackagesPageViewModel vm)
protected override void WhenShowingContextMenu(IPackage package)
{
if (_menuAsAdmin is null || _menuInteractive is null || _menuSkipHash is null
|| _menuDownloadInstaller is null || _menuOpenInstallLocation is null
|| _menuAutoUpdate is null)
|| _menuDownloadInstaller is null || _menuOpenInstallLocation is null)
{
Logger.Warn("Context menu items are null on SoftwareUpdatesPage");
return;
Expand All @@ -310,7 +289,6 @@ protected override void WhenShowingContextMenu(IPackage package)
_menuDownloadInstaller.IsEnabled = caps.CanDownloadInstaller;
_menuOpenInstallLocation.IsEnabled =
package.Manager.DetailsHelper.GetInstallLocation(package) is not null;
_menuAutoUpdate.IsChecked = AutoUpdatesDatabase.IsAutoUpdated(package);
}

// ─── Abstract action overrides ────────────────────────────────────────────
Expand Down Expand Up @@ -461,32 +439,6 @@ private static async Task WhenPackagesLoaded()
}
}

private static void MarkForAutoUpdates(IEnumerable<IPackage> packages)
{
int marked = 0;
foreach (var pkg in packages)
{
string id = AutoUpdatesDatabase.GetIdForPackage(pkg);
if (AutoUpdatesDatabase.IsAutoUpdated(id)) continue;
AutoUpdatesDatabase.Add(id);
marked++;
}

if (marked is 0) return;

var schedule = MaintenanceScheduleStore.Get(MaintenanceTaskKind.InstallUpdates);
string message = !schedule.Enabled
? CoreTools.Translate("Turn on \"Install available updates\" in the scheduled maintenance settings for this to take effect.")
: schedule.InstallTargets is ScheduleInstallTargets.AllPackages
? CoreTools.Translate("Every upgradable package is already installed automatically, so this changes nothing until the scheduled task is limited to marked packages.")
: CoreTools.Translate("They will be updated when the scheduled maintenance task runs.");

GetMainWindow()?.ShowBanner(
CoreTools.Translate("{0} package(s) marked for automatic updates", marked),
message,
MainWindow.RuntimeNotificationLevel.Success);
}

private static async Task LaunchScheduledUpdate(IReadOnlyList<IPackage> upgradable)
{
bool markedOnly = MaintenanceScheduleStore.GetInstallTargets()
Expand Down
Loading