Skip to content

Discard updates whose offered version is not newer than the installed… #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into from
Sep 30, 2026
Merged

Discard updates whose offered version is not newer than the installed… #5462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/UniGetUI.PackageEngine.PackageLoader/UpgradablePackagesLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ protected override async Task<bool> IsPackageValid(IPackage package)
if (package.VersionString == package.NewVersionString)
return false;

if (
package.NormalizedNewVersion != default
Comment thread
GabrielDuf marked this conversation as resolved.
&& package.Manager.CompareVersions(package.VersionString, package.NewVersionString)
is >= 0
)
{
Logger.Info(
$"Ignoring package {package.Id} because the offered version {package.NewVersionString} is not newer than the installed version {package.VersionString}."
);
return false;
}

if (package.NewerVersionIsInstalled())
{
Logger.Info(
Expand Down
57 changes: 57 additions & 0 deletions src/UniGetUI.PackageEngine.Tests/UpgradablePackagesLoaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,63 @@ await installedLoader.AddForeign(
Assert.True(await loader.EvaluatePackageAsync(package));
}

[Fact]
public async Task EvaluatePackageAsync_RejectsOlderOfferedVersionWithoutTheInstalledList()
{
var manager = new PackageManagerBuilder().Build();
_ = new InstalledPackagesLoader([manager]);
_ = new DiscoverablePackagesLoader([manager]);
var loader = new TestUpgradablePackagesLoader([manager]);

var package = new PackageBuilder()
.WithManager(manager)
.WithId("Daum.PotPlayer")
.WithVersion("260819")
.WithNewVersion("210428")
.Build();

Assert.False(await loader.EvaluatePackageAsync(package));
}

[Theory]
[InlineData("stable")]
[InlineData("latest")]
[InlineData("2.0.0_rc1")]
public async Task EvaluatePackageAsync_KeepsUpdatesWhoseOfferedVersionCannotBeParsed(string newVersion)
{
var manager = new PackageManagerBuilder().Build();
_ = new InstalledPackagesLoader([manager]);
_ = new DiscoverablePackagesLoader([manager]);
var loader = new TestUpgradablePackagesLoader([manager]);

var package = new PackageBuilder()
.WithManager(manager)
.WithId("org.contoso.Flatpak")
.WithVersion("3.2.1")
.WithNewVersion(newVersion)
.Build();

Assert.True(await loader.EvaluatePackageAsync(package));
}

[Fact]
public async Task EvaluatePackageAsync_KeepsUpdatesWhenTheInstalledVersionIsUnknown()
{
var manager = new PackageManagerBuilder().Build();
_ = new InstalledPackagesLoader([manager]);
_ = new DiscoverablePackagesLoader([manager]);
var loader = new TestUpgradablePackagesLoader([manager]);

var package = new PackageBuilder()
.WithManager(manager)
.WithId("Contoso.Unversioned")
.WithVersion("Unknown")
.WithNewVersion("210428")
.Build();

Assert.True(await loader.EvaluatePackageAsync(package));
}

[Fact]
public async Task ApplyWhenAddingPackageAsync_UpdatesDiscoverableAndInstalledTags()
{
Expand Down
Loading