Skip to content

Fix terminal confirmations, input responsiveness, and broker retention - #6

Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/terminal-reliability-cleanup
Sep 8, 2026
Merged

Fix terminal confirmations, input responsiveness, and broker retention#6
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/terminal-reliability-cleanup

Conversation

@mamoreau-devolutions

Copy link
Copy Markdown
Contributor

Summary

  • Enforce paste confirmation and implement configured window-close confirmation with asynchronous dialogs.
  • Keep terminal input ordered and bounded without blocking the UI; make the Unix relay nonblocking and apply shutdown deadlines.
  • Disable unsupported settings rather than presenting controls with no runtime effect.
  • Bound broker response retention while preserving in-flight deduplication.
  • Extract confirmation and lifecycle components from the main window and document behavior.

Validation

  • Application build and strict native compilation succeeded.
  • Windows: 305 tests passed, 9 platform skips.
  • Linux/WSL: 11 tests passed.
  • macOS was not tested.

Behavior notes

  • Automatic close confirmation protects multiple running sessions.
  • Cancelling an in-flight write terminates the session to avoid corrupted framing.

Wire safe asynchronous paste and close confirmation, bound ordered PTY input and broker request admission, make the Unix relay nonblocking, and clarify unsupported settings. Extract window lifecycle and confirmation components with behavioral regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cache only generated native outputs and require exact source and build-script hashes. Drop broad restore fallbacks that reused the old blocking PTY host and overwrote the updated relay source.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit 718218f into master Sep 8, 2026
24 checks passed
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) deleted the copilot/terminal-reliability-cleanup branch September 8, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant