fix(profile): only link to data recovery from the active account's profile - #23
Merged
Merged
Conversation
…ofile The Restore link on your own profile showed in any column that signs as one of your paired accounts, but the data recovery page always scans and restores the active account. From a column for a paired account that isn't active, the link opened recovery for a different account than the one on screen, without saying so. The link now shows only when the column signs as the active account. Also marks the profile field values in the recovery review dir="auto", since they are user-generated text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying jank with
|
| Latest commit: |
4d011f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b3d57a9a.jank-4ii.pages.dev |
| Branch Preview URL: | https://fix-profile-restore-link-act.jank-4ii.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #22 (data recovery by @dmnyc).
dir="auto"per the RTL rules in CLAUDE.md.A later improvement could make the recovery page use the column's account (
useAccountScopeOptional()) instead of the active one, so Restore works from any paired account's column. That's a larger change and not part of this PR.Testing
data-recovery-link.spec.ts. The "paired account that isn't active" case fails on the old rule (expected true to be false) and passes with the fix.npm run build,npx tsc -b,npm run lint(0 errors; 1 existing warning inBookmarksColumnBody.tsx), full suite: 977 passed, 1 skipped.🤖 Generated with Claude Code