Repository navigation
Fix the android widget, complete ten translations - #45
Merged
Merged
Conversation
Ten locales were already within thirty strings of complete; they are now at
635 of 635. The strings added are the ones this fork introduced - the name
operations, the chain mismatch warning, sending to a DoiAddress - plus those
BlueWallet added after each translation was last touched.
Every locale also carried keys English no longer has: 474 of them across 46
files, all from parts the fork removed. The Lightning strings reach only
screen/lnd, which no route has pointed at since the Lightning routes were
taken out, and settings.about_sm_telegram, about_sm_twitter and about_sm_discord
were the BlueWallet social links dropped from the About screen.
Seven translations had the placeholder itself translated, so the substitution
found nothing to replace and the braces reached the screen:
fr_fr Destinataire n° {nombre} sur {total}
sq_AL {numri} nga {totali}
fr_fr {octets} octets d'entropie
es_419 El archivo ({fileName}) ...
zh_cn 交易文件（{filepath}）已被保存。
pcm We nor fit connect to [server]
vi_vn {gen} ... {gen} bytes còn lại (the second should be {rem})
All seven now carry the English placeholder names. No placeholder in any of
the fifty translations differs from English.
Doichain#20
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The issue asks for a GitHub Action that calls a paid translation API and opens pull requests. This is the cheaper half of that: a script that says what is missing, what is left over, and - the part that reaches users - which placeholders no longer match English, since a translated placeholder name leaves literal braces on screen. It runs in the test job and reports without failing, so a translation that has not caught up cannot block a branch. Passing --strict makes it exit 1, if the project later wants that. No API key, no recurring cost, and nothing to review except the report. Doichain#20 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #28 and #20.
e2e is broken on dev.
ViewEditMultisigCosignersStack.tsximports a modulethat has never existed in the tree, so the job fails at "Build". Added;
testand
e2eboth pass.Android widget (#28). The 24h change printed every digit the API returned
(
31.979999542236328) — now rounded. The update worker was periodic-only withREPLACE, so it had never run once on the test device — a one-off request nowcarries the immediate update. The cached state printed the literal string
"volume", and the failure path threw on!!instead of showing the cache.Translations (#20). Ten locales complete at 635/635. 474 obsolete keys
removed from 46 files. Seven translations had the placeholder name itself
translated, so braces reached the screen (
{nombre},{filepath},{numri}).scripts/check-locales.jsreports all three and runs in CI withoutfailing it — no API key, no recurring cost.
Also: a slow wallet refresh was reported as failed; the android signing lane
treated an unset secret as present; the root
MasterView.tsxis a deadduplicate.